Jira (PUP-9262) Remove fine grained file and environment timeouts

15 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Oct 23, 2018, 6:26:33 PM10/23/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Puppet / Task PUP-9262
Remove fine grained file and environment timeouts
Change By: Josh Cooper
Team: Coremunity
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Oct 23, 2018, 6:26:42 PM10/23/18
to puppe...@googlegroups.com
Josh Cooper created an issue
Issue Type: Task Task
Assignee: Unassigned
Created: 2018/10/23 3:24 PM
Fix Versions: PUP 7.0.0
Priority: Normal Normal
Reporter: Josh Cooper

Puppet will let you set fine grained file and environment timeouts, but it doesn't really work. We are deprecating the ability to set the timeout to something other than "always cache" vs "never cache" in https://github.com/puppetlabs/puppet/pull/7001. This ticket is to disallow any values other than that.

 

Josh Cooper (JIRA)

unread,
Apr 4, 2019, 5:31:03 PM4/4/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Puppet will let you set fine grained file and environment timeouts, but it doesn't really work. We are deprecating the ability to set the timeout to something other than "always cache" vs "never cache" in [https://github.com/puppetlabs/puppet/pull/7001 . ] This ticket is to disallow any values other than that.

 

Josh Cooper (JIRA)

unread,
Jul 23, 2019, 6:26:02 PM7/23/19
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-9262
 
Re: Remove fine grained file and environment timeouts

The original motivation for this comes from Justin Stoller comment in https://github.com/puppetlabs/puppet/pull/7001:

See SERVER-2285 and SERVER-2028 for background on these two settings (and how they don't work well currently).

Justin Stoller (JIRA)

unread,
Jul 23, 2019, 7:46:02 PM7/23/19
to puppe...@googlegroups.com

Nick, it seems like using the per-environment environment.conf override abilities would help users with many short lived feature branches vs long lived branches like production. I would think users would want to set those short lived feature branches' environment_timeout to zero (either they're testing it on a box or iterating on code, but aren't using cached versions of old code) or they are in production (or a similar long lived environment like staging) and want unlimited caching managed by code-manager.

Melissa Stone (Jira)

unread,
Apr 29, 2020, 4:47:03 PM4/29/20
to puppe...@googlegroups.com
Melissa Stone commented on Task PUP-9262

Justin Stoller we should figure out what we want to do with this soon. Either we should remove the deprecation warning, or we should remove the fine-grained control. Coremunity doesn't have enough context on the work to make this decision.

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Melissa Stone (Jira)

unread,
Apr 29, 2020, 4:48:03 PM4/29/20
to puppe...@googlegroups.com
Melissa Stone updated an issue
 
Change By: Melissa Stone
Team: Coremunity Froyo

Justin Stoller (Jira)

unread,
Apr 29, 2020, 4:57:02 PM4/29/20
to puppe...@googlegroups.com
Justin Stoller commented on Task PUP-9262
 
Re: Remove fine grained file and environment timeouts

We've been talking more about environment ttls lately with the recent file-sync work. I think after this upcoming release we can look into whether the environment-ttl work will be doable in the pre-7 timeframe and if not we can remove the deprecation notice.

Josh Cooper (Jira)

unread,
Jul 21, 2020, 1:00:05 PM7/21/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Epic Link: PUP- 9120 10593

Rob Braden (Jira)

unread,
Jul 22, 2020, 7:05:03 PM7/22/20
to puppe...@googlegroups.com
Rob Braden updated an issue
Change By: Rob Braden
Labels: platform_7

Maggie Dreyer (Jira)

unread,
Aug 10, 2020, 1:47:02 PM8/10/20
to puppe...@googlegroups.com
Maggie Dreyer commented on Task PUP-9262
 
Re: Remove fine grained file and environment timeouts

Josh Cooper I confirmed with Froyo that we still consider https://tickets.puppetlabs.com/browse/PUP-8014 a pre-req for this work. Do you have a sense of what implementing environment_ttl would entail?

Maggie Dreyer (Jira)

unread,
Aug 14, 2020, 2:14:03 PM8/14/20
to puppe...@googlegroups.com
Maggie Dreyer commented on Task PUP-9262

Talked with Nick today, and we decided that if we're going to do something for 7 on this, we should implement environment_ttl and get rid of enviornment_timeout entirely. It probably makes sense to just file a new ticket for that second part, the first part is PUP-8014. We should discuss how this work would be best split between Froyo and Josh Cooper.

Maggie Dreyer (Jira)

unread,
Aug 14, 2020, 2:18:03 PM8/14/20
to puppe...@googlegroups.com

Dorin Pleava (Jira)

unread,
Nov 5, 2020, 4:16:03 AM11/5/20
to puppe...@googlegroups.com
Dorin Pleava updated an issue
 
Change By: Dorin Pleava
Fix Version/s: PUP 7.0.0
Reply all
Reply to author
Forward
0 new messages