Jira (FACT-2949) Facts that have a hash as a value cannot be extended by custom or external facts

Bogdan Irimie (Jira)

unread,

Feb 26, 2021, 10:50:01 AM2/26/21

to puppe...@googlegroups.com

Bogdan Irimie updated an issue

Facter /

FACT-2949

Facts that have a hash as a value cannot be extended by custom or external facts

Change By:	Bogdan Irimie
Summary:	Facts that have a hash ass as a value cannot be extended by custom or external facts

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Mihai Buzgau (Jira)

unread,

Feb 26, 2021, 10:53:01 AM2/26/21

to puppe...@googlegroups.com

Mihai Buzgau updated an issue

Facter /

FACT-2949

Facts that have a hash as a value cannot be extended by custom or external facts

Change By:	Mihai Buzgau
Team:	Night's Watch Ghost

Add Comment

Bogdan Irimie (Jira)

unread,

Feb 26, 2021, 10:59:10 AM2/26/21

to puppe...@googlegroups.com

Bogdan Irimie updated an issue

Facter /

FACT-2949

Facts that have a hash as a value cannot be extended by custom or external facts

Change By:	Bogdan Irimie

When trying to extend a fact that has a hash value with a custom fact, I get an error

E.g. If a try to extend the "disk" fact with
{code}Facter.add("disks.my_custom_disk2") do
  setcode do
    "d"
  end
end
{code}
and got
{code}[2021-02-26 12:35:46.784434 ] ERROR Facter::FactCollection - Custom fact `disks.my_custom_disk` cannot be added to collection. The format of this fact is incompatible with other facts that belong to `disks` group
{code}

Add Comment

Bogdan Irimie (Jira)

unread,

Mar 2, 2021, 7:08:56 PM3/2/21

to puppe...@googlegroups.com

Bogdan Irimie updated an issue

Facter /

FACT-2949

Facts that have a hash as a value cannot be extended by custom or external facts

Change By:	Bogdan Irimie

When trying to extend a fact that has a hash value with a custom fact, I get an error

E.g. If a try to extend the "disk" fact with
{code}Facter.add("disks.my_custom_disk2") do
  setcode do
    "d"
  end
end
{code}
and got
{code}[2021-02-26 12:35:46.784434 ] ERROR Facter::FactCollection - Custom fact `disks.my_custom_disk` cannot be added to collection. The format of this fact is incompatible with other facts that belong to `disks` group
{code}

Some facts (e.g. disks, networking.interfaces) have a hash as a value. If we want to override a value in the hash with a custom facts, we are not able to.

The suggestion is to extend [burry|https://github.com/puppetlabs/facter/blob/b7594837d72967e175c6ad0124a1377567f63904/lib/facter/models/fact_collection.rb#L26] from fact collection and allow burry insertions in hashes or transform the hash to a fact collection objects.