Jira (PUP-6634) environment.conf should use standard syntax for POSIX and Windows

4 views
Skip to first unread message

Kylo Ginsberg (JIRA)

unread,
Aug 18, 2016, 2:31:05 PM8/18/16
to puppe...@googlegroups.com
Kylo Ginsberg moved an issue
 
Puppet / Improvement PUP-6634
environment.conf should use standard syntax for POSIX and Windows
Change By: Kylo Ginsberg
Component/s: puppet
Issue Type: Bug Improvement
Key: PE PUP - 17148 6634
Project: Puppet  Enterprise [Internal]
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Atlassian logo

Kylo Ginsberg (JIRA)

unread,
Aug 18, 2016, 2:32:03 PM8/18/16
to puppe...@googlegroups.com
Kylo Ginsberg commented on Improvement PUP-6634
 
Re: environment.conf should use standard syntax for POSIX and Windows

Yep, moved to PUP and marked it as an Improvement idea. Thoughts on this suggestion, Henrik Lindberg or Ethan Brown?

Henrik Lindberg (JIRA)

unread,
Aug 18, 2016, 4:48:05 PM8/18/16
to puppe...@googlegroups.com
  • We could support only one of them (':' would be bad for Windows users, and ';' for Posix users) - we would need to deprecate "the other", and the annoy people with having to change.
  • We could support both - which could potentially be somewhat confusing. No deprecation needed, it is simply a new feature per the respective platform. There is a small problem that paths can then not contain the "other delimiter" as part of a path (that is probably a very small problem).

My vote goes to supporting both delimiters.

Nicholas Fagerlund (JIRA)

unread,
May 16, 2017, 5:56:04 PM5/16/17
to puppe...@googlegroups.com

I also vote for supporting both delimiters.

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Nicholas Fagerlund (JIRA)

unread,
May 16, 2017, 5:57:02 PM5/16/17
to puppe...@googlegroups.com

Nicholas Fagerlund (JIRA)

unread,
May 16, 2017, 5:57:03 PM5/16/17
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Mar 16, 2018, 4:31:04 PM3/16/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sub-team: Language
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 11, 2021, 1:45:03 AM6/11/21
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-6634
 
Re: environment.conf should use standard syntax for POSIX and Windows

The most common case is to use colon, which works as expected on POSIX.

Would could accept colon (in addition to semicolon) when running on Windows. Colons could cause confusion for things like foo:bar as o:bar is the path bar relative to the current directory on drive o.

Supporting semicolons (and colon) on POSIX seems pretty easy, we'd just need to split the modulepath on either [:;]. See Puppet::Node::Environment.split_path.

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

David McTavish (Jira)

unread,
Dec 6, 2021, 11:45:03 AM12/6/21
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Feb 8, 2022, 2:41:02 AM2/8/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Froyo
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages