Jira (PUP-10594) Lock termini creation

Justin Stoller (Jira)

unread,

Jul 21, 2020, 5:26:02 PM7/21/20

to puppe...@googlegroups.com

Justin Stoller created an issue

Puppet /

PUP-10594

Lock termini creation

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2020/07/21 2:25 PM
Priority:	Normal
Reporter:	Justin Stoller

We currently wrap indirector information (terminus class, cache class, etc) in threadlocal containers, however, we don't initialize and cache the termini themselves in a threadsafe way and they are created on first invocation of each indirection's terminus method (which may not be called until required to handle the first find-like method).

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Josh Cooper (Jira)

unread,

Jul 21, 2020, 7:04:03 PM7/21/20

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-10594

Lock termini creation

Change By:	Josh Cooper

We currently wrap indirector information (terminus class, cache class, etc) in threadlocal containers, however, we don't initialize and cache the termini themselves in a threadsafe way and they are created on first invocation of each indirection's {{terminus}} method (which may not be called until required to handle the first {{find}}-like method).

See https://github.com/puppetlabs/puppet/blob/a3e5bff533d04e13ed9098236e1fe0ec6463def1/lib/puppet/indirector/indirection.rb#L136-L141