Jira (PDB-4547) Add wire format validation for deactivate node commands

7 views
Skip to first unread message

Zachary Kent (JIRA)

unread,
Oct 7, 2019, 6:51:03 PM10/7/19
to puppe...@googlegroups.com
Zachary Kent created an issue
 
PuppetDB / Bug PDB-4547
Add wire format validation for deactivate node commands
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/10/07 3:50 PM
Priority: Normal Normal
Reporter: Zachary Kent

It appears that we're not adding wire format validation for deactivate node commands. See here An improperly formatted command will fail but not end up getting discarded to the dlo.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Zachary Kent (JIRA)

unread,
Oct 7, 2019, 6:52:03 PM10/7/19
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
It appears that we're not adding wire format validation for deactivate node commands. See [here|https://github.com/puppetlabs/puppetdb/blob/master/src/puppetlabs/puppetdb/command.clj#L378-L384] . An improperly formatted command will fail but not end up getting discarded to the dlo.



Zachary Kent (JIRA)

unread,
Oct 11, 2019, 12:57:04 PM10/11/19
to puppe...@googlegroups.com

Austin Blatt (JIRA)

unread,
Oct 22, 2019, 6:39:04 PM10/22/19
to puppe...@googlegroups.com
Austin Blatt updated an issue
Change By: Austin Blatt
Fix Version/s: PDB 5.2.11
Fix Version/s: PDB 6.7.2
Fix Version/s: PDB 6.3.6
Reply all
Reply to author
Forward
0 new messages