Jira (PUP-10653) Remove the Dir monkey-patch from Puppet if not used

[Gabriel Nagy (Jira)]

Gabriel Nagy created an issue

Puppet / PUP-10653 Remove the Dir monkey-patch from Puppet if not used Issue Type: Improvement Assignee: Unassigned Created: 2020/09/01 2:00 AM Priority: Normal Reporter: Gabriel Nagy We removed our external dependency on the win32-dir gem in PUP-6184 by pulling the gem code in puppet. However, it seems that win32-dir features are scarcely used outside of constants which can all be replaced by environment variables. We need to check if we're actually using anything from the dir monkey-patch. If not, we should remove it entirely. Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10653 Remove the Dir monkey-patch from Puppet if not used

Change By: Mihai Buzgau Labels: platform_7

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10653 Remove the Dir monkey-patch from Puppet if not used

Change By: Mihai Buzgau Story Points: 2

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10653 Remove the Dir monkey-patch from Puppet if not used

Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-09-16

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy assigned an issue to Gabriel Nagy

Puppet / PUP-10653 Remove the Dir monkey-patch from Puppet if not used

Change By: Gabriel Nagy Assignee: Gabriel Nagy

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10653

Re: Remove the Dir monkey-patch from Puppet if not used Merged to main in https://github.com/puppetlabs/puppet/commit/e677808a0ec761e54ad07dcfc6467a29eed39f71 Gabriel Nagy could you add release notes?

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10653

Remove the Dir monkey-patch from Puppet if not used

Change By: Josh Cooper Fix Version/s: PUP 7.0.0

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Puppet / PUP-10653 Remove the Dir monkey-patch from Puppet if not used

Change By: Gabriel Nagy Release Notes: Enhancement Release Notes Summary: Remove external dependency on the win32/dir gem and replace the usage of CSIDL constants with environment variables

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10653

Re: Remove the Dir monkey-patch from Puppet if not used Passed CI in e2a883df7e

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10653

Remove the Dir monkey-patch from Puppet if not used

Change By: Claire Cadman Labels: doc_reviewed platform_7

Add Comment