Jira (PUP-6829) Improve agent mutex on Windows

3 views
Skip to first unread message

James Stocks (JIRA)

unread,
Oct 17, 2016, 5:28:04 PM10/17/16
to puppe...@googlegroups.com
James Stocks created an issue
 
Puppet / Improvement PUP-6829
Improve agent mutex on Windows
Issue Type: Improvement Improvement
Affects Versions: PUP 4.7.1
Assignee: Unassigned
Components: Windows
Created: 2016/10/17 2:27 PM
Priority: Normal Normal
Reporter: James Stocks

Current behaviour:

  • puppet agent on Windows starts ruby.exe, that takes some time to launch, then ruby checks for an existing agent PID file and exits if puppet agent is already running

Suggestion:

  • Improve this so that puppet agent exits immediately. The time to launch ruby can be significant (~12 seconds on our Windows 2008 vmpooler VMs) and may cause complications with newer PE features that run puppet on demand.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Maggie Dreyer (JIRA)

unread,
May 16, 2017, 5:18:05 PM5/16/17
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
Change By: Maggie Dreyer
Labels: triaged

Josh Cooper (JIRA)

unread,
Mar 16, 2018, 2:38:04 PM3/16/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sub-team: Coremunity
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (Jira)

unread,
Mar 13, 2020, 6:13:04 PM3/13/20
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-6829
 
Re: Improve agent mutex on Windows

This used to be a problem because several destructive actions occurred outside of puppet's pidlock, such as SSL initialization, which could lead to mismatched CSR and private key. Now the SSL subsystem is protected with its own lock, so I think the only benefit here would be faster notification that a run was already in progress, but that seems fairly low priority, so I'm going to close this. Feel free to reopen if this is an issue.

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages