Jira (FACT-3096) facter execution API is stripping spaces

9 views
Skip to first unread message

Ciprian Badescu (Jira)

unread,
Nov 15, 2021, 4:58:03 AM11/15/21
to puppe...@googlegroups.com
Ciprian Badescu created an issue
 
Facter / Bug FACT-3096
facter execution API is stripping spaces
Issue Type: Bug Bug
Affects Versions: FACT 4.2.5
Assignee: Unassigned
Created: 2021/11/15 1:57 AM
Priority: Normal Normal
Reporter: Ciprian Badescu

Facter execution API is stripping leading and trailing white-spaces, observed while working on https://tickets.puppetlabs.com/browse/FACT-3094

Reproduction:

[root@urgent-equating ~]# gem install facter
Fetching: facter-4.2.5.gem (100%)
Successfully installed facter-4.2.5
1 gem installed
[root@urgent-equating ~]# echo X$(ruby -e "require 'facter'; puts Facter::Core::Execution.execute('echo \" A B \"') ")Y
XA BY

It's visible on all Facter 4 version, not on Facter 2

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Ciprian Badescu (Jira)

unread,
Nov 15, 2021, 8:25:03 AM11/15/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Facter execution API is stripping leading and trailing white-spaces, observed while working on https://tickets.puppetlabs.com/browse/FACT-3094

It's visible on all Facter 4 and Facter 3 version, not on Facter 2

Reproduction:
{code:java}
echo X$(/opt/puppetlabs/puppet/bin/ruby -e "require '/opt/puppetlabs/puppet/lib/libfacter.so'; puts Facter::Core::Execution.execute('echo \" A B \"') ")Y
XA BY
[root@urgent-equating ~]# gem install facter
Fetching: facter-4.2.5.gem (100%)
Successfully installed facter-4.2.5
1 gem installed
[root@urgent-equating ~]# echo X$(ruby -e "require 'facter'; puts Facter::Core::Execution.execute('echo \" A B \"') ")Y
XA BY
[root@urgent-equating ~]# gem uninstall facter
Remove executables:
facter

in addition to the gem? [Yn]  y
Removing facter
Successfully uninstalled facter-4.2.5
[root@urgent-equating ~]# gem install facter -v 2.5.7
Fetching: facter-2.5.7.gem (100%)
Successfully installed facter-2.5.7

1 gem installed
[root@urgent-equating ~]# echo X$(ruby -e "require 'facter'; puts Facter::Core::Execution.execute('echo \" A B \"') ")Y
X A B Y

{code}
It's visible on all Facter 4 version, not on Facter 2

Ciprian Badescu (Jira)

unread,
Nov 15, 2021, 8:26:02 AM11/15/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Facter execution API is stripping leading and trailing white-spaces, observed while working on https://tickets.puppetlabs.com/browse/FACT-3094

It's visible on all Facter 4 versions and in Facter 3 version , not on Facter 2

Reproduction:
{code:java}

[root@urgent-equating ~]# echo X$(/opt/puppetlabs/puppet/bin/ruby -e "require '/opt/puppetlabs/puppet/lib/libfacter.so'; puts Facter::Core::Execution.execute('echo \" A B \"') ")Y

XA BY
[root@urgent-equating ~]# gem install facter
Fetching: facter-4.2.5.gem (100%)
Successfully installed facter-4.2.5
1 gem installed
[root@urgent-equating ~]# echo X$(ruby -e "require 'facter'; puts Facter::Core::Execution.execute('echo \" A B \"') ")Y
XA BY
[root@urgent-equating ~]# gem uninstall facter
Remove executables:
facter

in addition to the gem? [Yn]  y
Removing facter
Successfully uninstalled facter-4.2.5
[root@urgent-equating ~]# gem install facter -v 2.5.7
Fetching: facter-2.5.7.gem (100%)
Successfully installed facter-2.5.7
1 gem installed
[root@urgent-equating ~]# echo X$(ruby -e "require 'facter'; puts Facter::Core::Execution.execute('echo \" A B \"') ")Y
X A B Y

{code}

Ciprian Badescu (Jira)

unread,
Nov 29, 2021, 10:35:02 AM11/29/21
to puppe...@googlegroups.com
Ciprian Badescu commented on Bug FACT-3096
 
Re: facter execution API is stripping spaces

Michael Smith, so you have any background info on this?

Michael Smith (Jira)

unread,
Nov 29, 2021, 1:03:03 PM11/29/21
to puppe...@googlegroups.com

Not really. I think that was just how Peter Huene decided to implement it in Facter 3. Relevant code is https://github.com/puppetlabs/facter/blob/3.x/lib/src/ruby/module.cc#L1030.

Reply all
Reply to author
Forward
0 new messages