Jira (PUP-11318) puppet code merger should use concat not plus

Issue Type:	Bug
Assignee:	Unassigned
Created:	2021/10/12 8:35 AM
Priority:	Normal
Reporter:	Josh Cooper

lib/puppet/pops/parser/code_merger.rb calls Array#+ which makes an unnecessary copy of parse results. It should call Array#concat instead

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

Josh Cooper (Jira)

unread,

Oct 12, 2021, 11:40:03 AM10/12/21

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Team:	Coremunity

Josh Cooper (Jira)

unread,

Oct 12, 2021, 11:41:03 AM10/12/21

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Sprint:	Coremunity Kanban

Josh Cooper (Jira)

unread,

Oct 12, 2021, 11:59:02 AM10/12/21

to puppe...@googlegroups.com

Josh Cooper assigned an issue to Josh Cooper

Puppet /

Change By:	Josh Cooper
Assignee:	Josh Cooper

Josh Cooper (Jira)

unread,

Oct 12, 2021, 12:34:03 PM10/12/21

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Fix Version/s:	PUP 6.26.0
Fix Version/s:	PUP 7.13.0

Josh Cooper (Jira)

unread,

Oct 15, 2021, 1:20:02 PM10/15/21

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper

lib/puppet/pops/parser/code_merger.rb calls Array#+ which makes an unnecessary copy of parse results. It should call Array# concat flat_map instead .

Josh Cooper (Jira)

unread,

Oct 15, 2021, 1:21:02 PM10/15/21

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Release Notes:	Bug Fix
Release Notes Summary:	Reduces memory usage when parsing manifests.

Josh Cooper (Jira)

unread,

Oct 18, 2021, 6:32:07 PM10/18/21

to puppe...@googlegroups.com

Josh Cooper commented on

Re: puppet code merger should use concat not plus

Merged to 6.x in https://github.com/puppetlabs/puppet/commit/bc8f433a41a00b34cf4fbadc1354fa53db2a525c

Josh Cooper (Jira)

unread,

Oct 20, 2021, 3:22:02 PM10/20/21

to puppe...@googlegroups.com

Josh Cooper commented on

Re: puppet code merger should use concat not plus

Passed CI in 8b4331b9f5

Parker Leach (Jira)

unread,

Dec 7, 2021, 11:10:02 PM12/7/21

to puppe...@googlegroups.com

Parker Leach updated an issue

Puppet /

Change By:	Parker Leach
Labels:	docs_reviewed