Jira (PUP-8246) Consolidate http client connection implementations

6 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Dec 13, 2017, 2:25:03 PM12/13/17
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-8246
Consolidate http client connection implementations
Issue Type: Task Task
Assignee: Unassigned
Created: 2017/12/13 11:24 AM
Priority: Normal Normal
Reporter: Josh Cooper

This ticket is a result of PUP-7482.

Puppet does not allow callers to specify which CA certs should be trusted when making SSL connections (see PUP-5069). As a result, there are three places where we create SSL connections, and configure the X509::Store:

1. puppet/network/http/factory
2. puppet/util/http_proxy
3. puppet/forge/repository

There are several inconsistencies as a result:

1. persistent connections are used for 1, but not 2
2. We send "Ruby" as the user-agent for 2
3. We don't send the X-PUPPET-VERSION header for 2
4. 1 and 2 handle proxy settings differently.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Josh Cooper (JIRA)

unread,
Aug 7, 2019, 7:59:03 PM8/7/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Aug 7, 2019, 8:00:05 PM8/7/19
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Sep 24, 2019, 7:48:03 PM9/24/19
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-8246
 
Re: Consolidate http client connection implementations

The work required to do this has been split into different tickets in this epic, so this ticket can be closed.

Reply all
Reply to author
Forward
0 new messages