Jira (FACT-3106) No virt-what in puppet-agent 7 so is_virtual is wrong

[Steve Traylen (Jira)]

Steve Traylen created an issue

Facter / FACT-3106 No virt-what in puppet-agent 7 so is_virtual is wrong Issue Type: Improvement Affects Versions: FACT 4.2.7 Assignee: Unassigned Components: Facter 4 Created: 2022/02/11 4:23 AM Environment: puppet-agent 7 facter 4 Priority: Normal Reporter: Steve Traylen In factor the is_virtual and other similar facts is very dependent upon  the virt-what command being availabe.   Since this commit to puppet-agent https://github.com/puppetlabs/puppet-agent/commit/a1a06ba3f42419e virt-what was removed from the puppet-agent package. I expect it may have been an unintentional consequence to stop these core facts from working out of the box with the puppet-agent package? Installing the system provide virt-what and everything works again but  this should be a dep or at least documented if that is the way forward.   For reference some history on the subject. https://tickets.puppetlabs.com/browse/FACT-822 Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Steve Traylen (Jira)]

Steve Traylen updated an issue

Facter / FACT-3106 No virt-what in puppet-agent 7 so is_virtual is wrong

Change By: Steve Traylen In factor the is_virtual and other similar facts is are very dependent upon  the virt-what command being availabe available .

Since this commit to puppet-agent [https://github.com/puppetlabs/puppet-agent/commit/a1a06ba3f42419e] virt-what was removed from the puppet-agent package. I expect it may have been an unintentional consequence to stop these core facts from working out of the box with the puppet-agent package?

Installing the system provide provided virt-what and everything works again but

this should be a dep or at least documented if that is the way forward.   For reference some history on the subject. https://tickets.puppetlabs.com/browse/FACT-822

Add Comment

[Tim Meusel (Jira)]

Tim Meusel updated an issue

Facter / FACT-3106 No virt-what in puppet-agent 7 so is_virtual is wrong

Change By: Tim Meusel In factor facter the is_virtual and other similar facts are very dependent upon  the virt-what command being available.

Since this commit to puppet-agent [https://github.com/puppetlabs/puppet-agent/commit/a1a06ba3f42419e] virt-what was removed from the puppet-agent package. I expect it may have been an unintentional consequence to stop these core facts from working out of the box with the puppet-agent package?

Installing the system provided virt-what and everything works again but

this should be a dep or at least documented if that is the way forward.   For reference some history on the subject. https://tickets.puppetlabs.com/browse/FACT-822

Add Comment

[Steve Traylen (Jira)]

Steve Traylen commented on FACT-3106

Re: No virt-what in puppet-agent 7 so is_virtual is wrong For similar reasons requiring pciutils for lspci is also a good idea.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3106

No virt-what in puppet-agent 7 so is_virtual is wrong

Change By: Josh Cooper Team: Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-3106

Re: No virt-what in puppet-agent 7 so is_virtual is wrong Ah the intention was to move virt-what to the puppet-runtime project (which contains all of our native dependencies). For this ticket we should: Add the dmidecode and virt-what components and patches to puppet-runtime Add those components to the agent-runtime-main project It's not necessary to add them to the agent-runtime-6.x project, since the dependencies still exist in puppet-agent#6.x traylenator It doesn't appear we shipped lspci or pciutils in puppet-agent 6.x, so I'd like to keep this ticket focused on fixing the regression with virt-what and dmidecode. Could you file a separate feature request for lspci/pciutils?

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3106

No virt-what in puppet-agent 7 so is_virtual is wrong

Change By: Josh Cooper Sprint: Phoenix 2022-05-11

Add Comment