Jira (PUP-8482) Create a formal representation of the AST that can replace the current dump format

1 view
Skip to first unread message

Thomas Hallgren (JIRA)

unread,
Feb 22, 2018, 9:07:04 AM2/22/18
to puppe...@googlegroups.com
Thomas Hallgren created an issue
 
Puppet / New Feature PUP-8482
Create a formal representation of the AST that can replace the current dump format
Issue Type: New Feature New Feature
Assignee: Thomas Hallgren
Created: 2018/02/22 6:06 AM
Priority: Normal Normal
Reporter: Thomas Hallgren

A formal representation of the Puppet AST is needed for multiple purposes:

  1. The current output from puppet parser dump is undocumented and not distinct enough to fully represent the AST (the AST cannot be recreated from this dump since some information is lost).
  2. A well documented and unambiguous format is required to make it API.
  3. A format is needed to facilitate cross-platform test suites for the parser.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Feb 22, 2018, 9:27:02 AM2/22/18
to puppe...@googlegroups.com
Henrik Lindberg commented on New Feature PUP-8482
 
Re: Create a formal representation of the AST that can replace the current dump format
  • The puppet parser dump needs to accept a flag for the new format so that those that use the old can continue doing so. For example --format=6.
  • It also needs to emit a deprecation warning for the regular format (that we can name format=5).
  • We need a ticket for Puppet 6.0.0 where the default format becomes 6.
  • We need to decide on when the old format is to be removed as we also need to update all of the tests that currently use the old format. (Or at least, make the old format not be available via the command line).

Henrik Lindberg (JIRA)

unread,
Feb 22, 2018, 9:27:04 AM2/22/18
to puppe...@googlegroups.com

Maybe there is more to the format, as you may want the new PN format, or JSON.

Thomas Hallgren (JIRA)

unread,
Feb 22, 2018, 5:11:02 PM2/22/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Feb 26, 2018, 12:15:02 PM2/26/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Feb 26, 2018, 12:15:03 PM2/26/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Feb 26, 2018, 12:19:04 PM2/26/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Sub-team: Language
Release Notes Summary: The S-Expression (clojure style data) format generated by {{puppet parser dump}} has been formalized and updated and is now considered a supported API for tools integration. The new format is available in text form as well as a Json version using the flag {{\--format}} with either {{pn}} for the new format, or {{json}} for the new format in Json. The old format is still the default, but is deprecated and will be removed in the next major version of puppet.
Sprint: Platform Core KANBAN
Release Notes: New Feature

Thomas Hallgren (JIRA)

unread,
Mar 1, 2018, 5:45:02 PM3/1/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Mar 2, 2018, 5:40:03 AM3/2/18
to puppe...@googlegroups.com
 
Re: Create a formal representation of the AST that can replace the current dump format

Merged to puppet master. Some minor changes requested on the specification.

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Mar 2, 2018, 5:40:03 AM3/2/18
to puppe...@googlegroups.com

Thomas Hallgren (JIRA)

unread,
Mar 3, 2018, 7:07:02 AM3/3/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Mar 4, 2018, 5:32:02 AM3/4/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Mar 4, 2018, 5:34:02 AM3/4/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Release Notes Summary: The S-Expression (clojure style data) format generated by {{puppet parser dump}} has been formalized and updated and is now considered a supported API for tools integration. The new format is available in text form as well as a Json version using the flag {{\--format}} with either {{pn}} for the new format, or {{json}} for the new format in Json. The flag {{\--pretty}} will add line breaks and indentation for the purpose of increasing readability.

The
old format is still the default for {{puppet parser dump}} , but is deprecated and will be removed in the next major version of puppet.

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:55:04 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
Reply all
Reply to author
Forward
0 new messages