Jira (PUP-5652) Windows Package provider does not work with Installshield with MSI files

[Corey Osman (JIRA)]

Corey Osman created an issue

Puppet / PUP-5652 Windows Package provider does not work with Installshield with MSI files Issue Type: Bug Affects Versions: PUP 3.8.0 Assignee: Aaron Armstrong Components: PE, Types and Providers Created: 2016/01/05 1:46 PM Environment: PE 3.8 Priority: Normal Reporter: Corey Osman Reference Material: http://unattended.sourceforge.net/installers.php (InstallShield with MSI) The windows package provider incorrectly quotes or adds a space when combining the install options. Because the Installshield installer is a wrapper exe for another installer, options must be specially quoted and passed in as an argument. However, puppet can't seem to get the quotes right no matter what I do. Example: $arg_params = "MANAGEMENT_SERVER=${management_server} /l*v! ${install_log} /qn" $package_name = 'Symantec Critical System Protection Agent' package {$package_name : ensure => $ensure_value, source => $source_path, install_options => ['/s', "/v\"${arg_params}\"], } The result of the install options should be ./installer.exe /s /v"MANAGEMENT_SERVER=1.1.1.1 /l*v! c:\temp\log.txt /qn" Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

[Aaron Armstrong (JIRA)]

Aaron Armstrong assigned an issue to Unassigned

Puppet / PUP-5652 Windows Package provider does not work with Installshield with MSI files

Change By: Aaron Armstrong Assignee: Aaron Armstrong

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-5652 Windows Package provider does not work with Installshield with MSI files

Change By: Josh Cooper Scrum Team: Windows

Add Comment

[Kenaz Kwa (JIRA)]

Kenaz Kwa updated an issue

Puppet / PUP-5652 Windows Package provider does not work with Installshield with MSI files

Change By: Kenaz Kwa Team: Agent & Platform Support

Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Geoff Nichols (JIRA)]

Geoff Nichols commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files Corey Osman, can you include an example of the incorrect quoting from a resulting puppet run?

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Rob Reynolds (JIRA)]

Rob Reynolds commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

The space in the arg_params causes Puppet to split the items out. If you want this to work properly Corey Osman, you will need to pass your arguments like this instead: install_options => ['/s', "/v\"MANAGEMENT_SERVER=${management_server}", '/l*v!', "${install_log}", '/qn','"'], Note two things - your arguments did not close out the quotes. And that you are running into a Puppet design where it will automatically quote a space in install options. The above is the only workaround for what you are attempting to do. If you want to get a detailed explanation of this behavior and why it works the way it does, see https://forge.puppet.com/puppetlabs/chocolatey#install-options-with-quotes--spaces

Add Comment

[Rob Reynolds (JIRA)]

Rob Reynolds commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

The windows package provider incorrectly quotes or adds a space when combining the install options. It's not incorrect, but it is annoying when you don't want it to automatically quote values when there are spaces.

Add Comment

[Rob Reynolds (JIRA)]

Rob Reynolds commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

I feel this can be closed as won't fix as it is part of the design of Puppet, although it may need some better documentation that notes what I already have in the Chocolatey provider about how install options auto-quotes options with spaces.

Add Comment

[Rob Reynolds (JIRA)]

Rob Reynolds commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

If it is something that should be fixed, it would likely hit a major version boundary as it could break a world of Puppet manifests.

Add Comment

[Rob Reynolds (JIRA)]

Rob Reynolds updated an issue

Puppet / PUP-5652

Windows Package provider does not work with Installshield with MSI files

Change By: Rob Reynolds Comment:

If it is something that should be fixed, it would likely hit a major version boundary as it could break a world of Puppet manifests.

Add Comment

[Rob Reynolds (JIRA)]

Rob Reynolds updated an issue

Puppet / PUP-5652 Windows Package provider does not work with Installshield with MSI files

Change By: Rob Reynolds Comment: {quote}The windows package provider incorrectly quotes or adds a space when combining the install options.{quote}

It's not incorrect, but it is annoying when you don't want it to automatically quote values when there are spaces.

Add Comment

[Corey Osman (JIRA)]

Corey Osman commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files Do I still need to provide an example? I am upgrading to PE 2016 and will check if the problem still exists. Rob Reynolds I wish I could use chocolatey but at the time there was no enterprise edition as our systems don't have internet.

Add Comment

[Rob Reynolds (JIRA)]

Rob Reynolds commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

Corey Osman Internet has never been required. You've been able to use internal sources since 2011 when Chocolatey first came out. Enterprise editions not required. Too bad for misinformation.

Add Comment

[Corey Osman (JIRA)]

Corey Osman commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

Rob Reynolds It is not about having internal sources. It is about having to recreate all the choco packages that have hard coded external dependencies.

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-5652

Windows Package provider does not work with Installshield with MSI files

Change By: Ethan Brown Labels: triaged

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-5652 Windows Package provider does not work with Installshield with MSI files

Change By: Branan Riley Labels: package triaged type_and_provider windows

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files Since this was filed the windows package provider was split into different classes for managing exe and msi packages. Can you try to reproduce using a newer version of puppet to see if it is still an issue?

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Corey Osman (Jira)]

Corey Osman commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

This was so long ago.  I have no desire to test this.  I would agree with Rob that the docs should be updated with his example unless they already have been.  I would just close the ticket.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-5652

Re: Windows Package provider does not work with Installshield with MSI files

Thanks Corey Osman, we should mention that here https://puppet.com/docs/puppet/6/resources_package_windows.html#resources_package_windows-install-and-uninstall-options I'll convert this to a DOCS ticket

Add Comment