Jira (PUP-8631) --tags should override individual --skip_tags

1 view
Skip to first unread message

Jo Rhett (JIRA)

unread,
Apr 4, 2018, 2:38:04 PM4/4/18
to puppe...@googlegroups.com
Jo Rhett created an issue
 
Puppet / New Feature PUP-8631
--tags should override individual --skip_tags
Issue Type: New Feature New Feature
Affects Versions: PUP 5.5.0
Assignee: Unassigned
Created: 2018/04/04 11:37 AM
Priority: Normal Normal
Reporter: Jo Rhett

Puppet Version: 4.4 through 5.5 and HEAD
Puppet Server Version: n/a
OS Name/Version: all

We were extremely grateful to see skip_tags added as a configuration option. This has been tremendously useful. However in practice we've started to see problems when multiple teams make use of the tag for different purposes. Example:

skip_tags = monitoring_changes,app_deploy

These tags are used by two different teams to limit changes to things the other team are unaware of, and not responsible for managing.

Desired Behavior:

If tags includes a tag in skip_tags then it should override that tag individually, rather than requiring the entire skip tags to be provided sans the one tag. So if this command is run:

puppet agent --test --tags app_deploy

It should not make monitoring changes, and vice versa.

Actual Behavior:

A person must lookup the current skip_tags and remove the desired tag. This is a manual process that involves some human failures as skip_tags can vary from node to node. It also makes automation tricky.

grep skip_tags /etc/puppetlabs/puppet/puppet.conf | split -d=  -f2 | awk... 

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Apr 4, 2018, 8:06:04 PM4/4/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity

Ben Ford (JIRA)

unread,
Apr 9, 2018, 7:26:03 PM4/9/18
to puppe...@googlegroups.com
Ben Ford commented on New Feature PUP-8631
 
Re: --tags should override individual --skip_tags

I think the generalizable solution here is that there should be a way of indicating that --tags and --skip_tags are inverses of each other (or something like inverse) and have the one specified at the more specific scope take precedence. In other words, whichever was specified at the command line would override the other.

Jorie Tappa (JIRA)

unread,
May 13, 2019, 2:09:04 PM5/13/19
to puppe...@googlegroups.com
Jorie Tappa updated an issue
 
Change By: Jorie Tappa
Component/s: Docs
Reply all
Reply to author
Forward
0 new messages