Dropped frames now Warnings since c9ee3b0?

[Jonathan Whiting]

Hi there,

I've been updating some old code to the latest version of psmoveapi, and thankfully functionally things have been going very smoothly! A very painless update considering I last touched this code in 2018, thank you!

However one thing that is causing some mild concern, is that I am now seeing a large volume of dropped frames warnings once I have a controller connected e.g:

[WARNING psmove.c: 1466] Dropped frames (seq 11 -> 13)
[WARNING psmove.c: 1466] Dropped frames (seq 14 -> 0)
[WARNING psmove.c: 1466] Dropped frames (seq 1 -> 3)
[WARNING psmove.c: 1466] Dropped frames (seq 4 -> 6)

After a bit of poking around, it seems that I am seeing this now, having updated, because this WARNING was previously a DEBUG message, and therefore not displayed in a default build of the api.  This is the relevant change https://github.com/thp/psmoveapi/commit/c9ee3b01b32f63ad5c5d12a76df7265b480b7523 "New logging macros"

Presumably my code has always been repeatedly failing this check (and we, e.g. shipped Sportsfriends in this state), but I wasn't getting the message spam because I wasn't using a Debug build of the api. Functionality wise, my controllers seem to be working fine.

So, I have two questions really:

First is whether these "Dropped frames" checks are something I _should_ be worrying about, and if so, what do I need to do?

Second is if it's appropriate for WARNING level messages to be sent every frame like this, and if there's anything we can do to reduce the amount of noise? e.g. could we report just once that frames are being regularly dropped, instead of reporting every dropped frame? If this is a sensible suggestion I'm happy to write some code to support it!

Cheers!

  Jonathan