configure not failing when mandatory dependecies are missing

[Didier]

Hi,

  When I wanted to build the latest  version of psensor on my old Debian, I had some issues because configure succeeded even if some mandatory build dependencies were missing. Currently, when mandatory build dependencies are missing, configure displays a warning in the middle of the log  and  ends happily. Then 'make all' will not create any binary.

  Is there a reason/ for configure not considering missing mandatory dependencies as an error ?

  If not, a change along those lines could help (it shows only one of several mandatory dependencies that only display a warning)

diff --git a/configure.ac b/configure.ac
index 5ef333c..5900651 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,7 +61,7 @@ AC_SUBST(SENSORS_LIBS)

 ### Required

-PKG_CHECK_MODULES(X11, x11,,[AC_MSG_WARN("x11 missing psensor will not be built")])
+PKG_CHECK_MODULES(X11, x11,,[AC_MSG_ERROR("x11 missing psensor cannot be built. Please install the x11 development package (typically named libx11-dev)")])
 AM_CONDITIONAL(X11, test -n "$X11_LIBS")
 AC_SUBST(X11_CFLAGS)
 AC_SUBST(X11_LIBS)

Didier

[jeanfi]

Hello Didier,

For this one, the reason is that psensor-server does not require X11 and
you might want to build only this program.

Regards,
jeanFI.

[Didier]

Thanks jeanFI. The dev package I was missing was actually UI related.

Didier.