configure not failing when mandatory dependencies are missing

[didier...@gmail.com]

Hi,

  When I wanted to build the latest version of psensor on my old Debian, I faced some challenges because configure  succeeded although some  mandatory build dependencies were missing on my computer.

  Is there a reason why configure is not failing when a mandatory build dependency is missing ?   Currently, when a dependency is missing for psensor, configure only displays a warning in the middle of its log, but then make produces no binary.

  An error message, as illustrated in the patch below could  produce a more visible message. (Only one example  of several occurrences with "blabla missing psensor will not be built".

 

 

diff --git a/configure.ac b/configure.ac
index 5ef333c..5900651 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,7 +61,7 @@ AC_SUBST(SENSORS_LIBS)

 ### Required

-PKG_CHECK_MODULES(X11, x11,,[AC_MSG_WARN("x11 missing psensor will not be built")])
+PKG_CHECK_MODULES(X11, x11,,[AC_MSG_ERROR("x11 missing psensor cannot be built. Please install the X11 development package (typically named libx11-dev)")])
 AM_CONDITIONAL(X11, test -n "$X11_LIBS")
 AC_SUBST(X11_CFLAGS)
 AC_SUBST(X11_LIBS)

Didier.