provy - Column width of 80 characters

[diogo...@gmail.com]

Se tiver problemas para visualizar este formulário, você poderá preenchê-lo on-line:
https://docs.google.com/spreadsheet/viewform?fromEmail=true&formkey=dC1fWGxqQ0EtMGRxX0tvRllvcGNNUXc6MQ

provy - Column width of 80 characters

Should we migrate our provy codebase to a maximum of 79 chars in each line of code, as defined in PEP8? (http://www.python.org/dev/peps/pep-0008/#maximum-line-length)

Should we stick to 79 chars? * http://www.python.org/dev/peps/pep-0008/#maximum-line-length

• Yes, absolutely! All our codebase should be below 80 chars!
• No, not at all! We shouldn't be restrained by this, anyhow!
• Well, yes, but for documentation only. Not needed for actual code.
• Well, yes, but for actual code only. Not needed for documentation.
• Outro:

Your name * To help understanding each contributor's preferences, and check that you're a provy community member

Tecnologia Google Docs Denunciar abuso - Termos de Serviço - Termos Adicionais

[Diogo Baeder]

Hi guys,

We've been receiving some contributions, lately, that contain code formatting to less than 80 chars of column width. So, instead of enforcing a past decision that may not please enough contributors anymore - as we have new contributors participating, today -, I thought it would be more sensible to just send a poll to ask what the community thinks now about this subject, leading us to a more democratic participation of contributors.

So please answer the poll above, and, based on its results, I suggest we change our codebase if most of the contributors prefer to keep it under 80 chars of line length.

Cheers,

__________________________
Diogo Baeder
http://diogobaeder.com.br

--
 
 

[Diogo Baeder]

Oh, and sorry for the Portuguese text in the form, I forgot to switch my Google account language before creating it...

"Outro" means "other", in English.

Seeya!

__________________________
Diogo Baeder
http://diogobaeder.com.br

[Fernando]

On 28 January 2013 00:44, Diogo Baeder <diogo...@gmail.com> wrote:

Hi guys,

We've been receiving some contributions, lately, that contain code formatting to less than 80 chars of column width. So, instead of enforcing a past decision that may not please enough contributors anymore - as we have new contributors participating, today -, I thought it would be more sensible to just send a poll to ask what the community thinks now about this subject, leading us to a more democratic participation of contributors.

So please answer the poll above, and, based on its results, I suggest we change our codebase if most of the contributors prefer to keep it under 80 chars of line length.

I like the 79 char limit for a few reasons and try to fit it in all my python code. But for provy, I find it hard sometimes because of the cli commands, breaking commands, even with implicit concatenation feels weird to me, because it may be breaking a word, not sentences.

So, in these cases, I like the django advice[1]:
"Don’t limit lines of code to 79 characters if it means the code looks significantly uglier or is harder to read."

So, I try to limit it to 79 characters, if I find it easier to read.

[1] https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/

Cheers,

__________________________
Diogo Baeder
http://diogobaeder.com.br

On Mon, Jan 28, 2013 at 1:38 AM, <diogo...@gmail.com> wrote:

Se tiver problemas para visualizar este formulário, você poderá preenchê-lo on-line:
https://docs.google.com/spreadsheet/viewform?fromEmail=true&formkey=dC1fWGxqQ0EtMGRxX0tvRllvcGNNUXc6MQ

provy - Column width of 80 characters

Should we migrate our provy codebase to a maximum of 79 chars in each line of code, as defined in PEP8? (http://www.python.org/dev/peps/pep-0008/#maximum-line-length)

Should we stick to 79 chars? * http://www.python.org/dev/peps/pep-0008/#maximum-line-length

• Yes, absolutely! All our codebase should be below 80 chars!
• No, not at all! We shouldn't be restrained by this, anyhow!
• Well, yes, but for documentation only. Not needed for actual code.
• Well, yes, but for actual code only. Not needed for documentation.
• Outro:

Your name * To help understanding each contributor's preferences, and check that you're a provy community member

Tecnologia Google Docs Denunciar abuso - Termos de Serviço - Termos Adicionais

--
 
 

--
http://about.me/fernandogrd

[Diogo Baeder]

Thanks, Fernando. I guess Jacek does about the same. I've asked him to avoid re-formatting, to avoid pull requests bigger than needed, but maybe I should reconsider, depending on what the contributors say.

Cheers!

__________________________
Diogo Baeder
http://diogobaeder.com.br

--
http://about.me/fernandogrd

--
 
 

[Fernando]

On 28 January 2013 10:20, Diogo Baeder <diogo...@gmail.com> wrote:

Thanks, Fernando. I guess Jacek does about the same. I've asked him to avoid re-formatting, to avoid pull requests bigger than needed, but maybe I should reconsider, depending on what the contributors say.

I think it depends, re-formatting existing code in commits that are about bugs or features may add extra noise. I think it is ok for new code or commits that are just for that.
 

--
 
 

--
http://about.me/fernandogrd