flake8 - internal quality

[Diogo Baeder]

Hi guys,

I introduced flake8 to provy today, so that it helps us keep tracking and improve the internal quality of our project. It won't be used as a step in our continuous integration builds, since we don't follow all of flake8's rules (mainly line length, which we don't keep at 79 chars max), but it can be helpful when we're making changes to the project, in order to keep it as clean as we can. I've already removed all unused imports with its help.

So, to use it:

1. Pull the project;

2. Install the REQUIREMENTS;

3. Run "make build" - this will run the tests first, and then run flake8 in our entire project, but bypass the "line is too long" complaints -.

Happy New Year, everyone! :-)

__________________________
Diogo Baeder
http://diogobaeder.com.br

[Fernando]

On 30 December 2012 22:17, Diogo Baeder <diogo...@gmail.com> wrote:
> Hi guys,
>
> I introduced flake8 to provy today, so that it helps us keep tracking and
> improve the internal quality of our project. It won't be used as a step in
> our continuous integration builds, since we don't follow all of flake8's
> rules (mainly line length, which we don't keep at 79 chars max), but it can
> be helpful when we're making changes to the project, in order to keep it as
> clean as we can. I've already removed all unused imports with its help.

Nice!
About the 79 chars limit, I like it, but I agree with not following
because I find it hard to strict it in provy code because of command
lines that get longs easy and sometimes it doesn't look good using
implicit string concatenation.

[]s

>
> So, to use it:
> 1. Pull the project;
> 2. Install the REQUIREMENTS;
> 3. Run "make build" - this will run the tests first, and then run flake8 in
> our entire project, but bypass the "line is too long" complaints -.
>
> Happy New Year, everyone! :-)
> __________________________
> Diogo Baeder
> http://diogobaeder.com.br

--
http://about.me/fernandogrd

[Diogo Baeder]

Good news! Just found out how to ignore line length errors, so I've bypassed them and made the "build" target the one to be executed at travis.ci! :-)

If anyone disagrees, please tell me so, and I'll revert back to "make test" instead.

Cheers!

__________________________
Diogo Baeder
http://diogobaeder.com.br