functional and PyVows tests

[Diogo Baeder]

Hi guys,

I've created a functional test, these days, to test the provy.core.runner module, so that we have some coverage over what it does when the command line script is launched. This and the unit tests we have are being exercised under continuous integration, in travis.ci.

However, we have a few other functional tests and PyVows tests that don't seem to be getting too much attention lately, and are not running in an automatic fashion. Besides, they don't cover as much of our application as the other tests cover, today. So I started asking myself how benefitial it is to still have them in our codebase.

Therefore, I'd like to suggest either of these two approaches to avoid having them as dead code in our source code:

1. We add them to our continuous integration process (not sure how to do this with the functional tests, though, given the simplicity of travis.ci, since we would need to spawn another VM to run them; But the PyVows tests could be added as another step in our build just fine)

2. We just say goodbye to them, and remove from our codebase.

My intention with this is to have meaninful value for every bit of code that we have, otherwise we will still have to maintain code that is not used. (For example, one of the problems that I'm having is that there are several complaints by flake8 for these tests, and I'm not sure I should fix them.)

What do you think? Should we go with one of the approaches above? Or do you have any other suggestions? I'm all ears! :-)

Cheers,

__________________________
Diogo Baeder
http://diogobaeder.com.br

[Bernardo Heynemann]

Delete them if we got coverage with the other tests