Java 9

116 views
Skip to first unread message

Ari Maniatis

unread,
May 23, 2018, 11:28:56 PM5/23/18
to protostuff
Is there much work required to bring protobuf up to Java 9? I see some tasks like https://github.com/protostuff/protostuff/issues/239  but does anyone have visibility on how much work is needed to fix this?

I know this project is mostly dormant, but its also mostly bug free, so not a lot of development is needed. But I think this one is going to start to cause issues.

David Yu

unread,
May 23, 2018, 11:31:12 PM5/23/18
to protostuff
On Thu, May 24, 2018 at 10:43 AM, Ari Maniatis <aristedes...@gmail.com> wrote:
Is there much work required to bring protobuf up to Java 9?
Not much but the devs don't use that version which is a problem.  No proper tests for a solution. 
I see some tasks like https://github.com/protostuff/protostuff/issues/239  but does anyone have visibility on how much work is needed to fix this?
 

I know this project is mostly dormant, but its also mostly bug free, so not a lot of development is needed. But I think this one is going to start to cause issues. 

--
You received this message because you are subscribed to the Google Groups "protostuff" group.
To unsubscribe from this group and stop receiving emails from it, send an email to protostuff+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
When the cat is away, the mouse is alone.
dyuproject.com

Steve Carlin

unread,
May 28, 2019, 2:09:53 PM5/28/19
to protostuff
Forgive my newbieness here if I'm asking something obvious.  I know I'm adding to a question that's a year old, hope this gets a response.

I may have run into a java 9 issue.  I'm trying to compile an existing open source project using mvn that works fine with java 8.  When I set my java to java11, I hit issues with protostuff.

Specifically, I think maybe it's because java 8 relies on javax.annotations.Generated while java 9 relies on javax.annotations.processing.Generated?  The generated file has javax.annotations.Generated in it.

I did see this (but I'll admit I don't follow everything completely): https://github.com/grpc/grpc-java/issues/3633

So question:  Is the "correct" fix to change the protostuff to generate the java 9 version of "Generated"?  I'm hesitant to hack around the issue.  Or am I totally off base?

Thanks!

Reply all
Reply to author
Forward
0 new messages