Issue 388 in protobuf: Patch of /protobuf/src/google/protobuf/compiler/command_line_interface.cc

[prot...@googlecode.com]

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 388 by Alexande...@mail.ru: Patch of
/protobuf/src/google/protobuf/compiler/command_line_interface.cc
http://code.google.com/p/protobuf/issues/detail?id=388

line 913:
replace
proto_path_.push_back(make_pair<string, string>(virtual_path, disk_path));
to
proto_path_.push_back(make_pair(virtual_path, disk_path));

Otherwise VC++11 (when use new standard) not compile libprotoc, error:

2>ClCompile:
2> command_line_interface.cc
2>..\src\google\protobuf\compiler\command_line_interface.cc(913): error
C2664: 'std::make_pair' : cannot convert parameter 1 from 'std::string'
to 'std::string &&'
2> You cannot bind an lvalue to an rvalue reference

[prot...@googlecode.com]

Comment #1 on issue 388 by Alexande...@mail.ru: Patch of
/protobuf/src/google/protobuf/compiler/command_line_interface.cc
http://code.google.com/p/protobuf/issues/detail?id=388

I'm compile for x64 architecture.

[prot...@googlecode.com]

Updates:
Status: Accepted

Comment #2 on issue 388 by liuj...@google.com: Patch of
/protobuf/src/google/protobuf/compiler/command_line_interface.cc
http://code.google.com/p/protobuf/issues/detail?id=388

The make_pair related violation will be fixed in the next release.

[prot...@googlecode.com]

Updates:
Status: Started
Owner: xiaof...@google.com

Comment #3 on issue 388 by xiaof...@google.com: Patch of
/protobuf/src/google/protobuf/compiler/command_line_interface.cc
http://code.google.com/p/protobuf/issues/detail?id=388

(No comment was entered for this change.)

[prot...@googlecode.com]

Updates:
Status: Duplicate
Mergedinto: 379

Comment #4 on issue 388 by xiaof...@google.com: Patch of