Issue 570 in protobuf: build 2.4.1 failed on mac os x 10.9

[prot...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 570 by mail.lus...@gmail.com: build 2.4.1 failed on mac os x 10.9
http://code.google.com/p/protobuf/issues/detail?id=570

What steps will reproduce the problem?
1. when run make then it failed
2. after i edit the google/protobuf/message.h file and added #include
<sstream> it become ok when I run make again

What is the expected output? What do you see instead?
the output like this :
/bin/sh ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I.
-I.. -D_THREAD_SAFE -Wall -Wwrite-strings -Woverloaded-virtual
-Wno-sign-compare -O2 -g -DNDEBUG -MT message.lo -MD -MP
-MF .deps/message.Tpo -c -o message.lo `test
-f 'google/protobuf/message.cc' || echo './'`google/protobuf/message.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -D_THREAD_SAFE -Wall
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -O2 -g -DNDEBUG -MT
message.lo -MD -MP -MF .deps/message.Tpo -c google/protobuf/message.cc
-fno-common -DPIC -o .libs/message.o
google/protobuf/message.cc:130:60: error: implicit instantiation of
undefined template 'std::__1::basic_istream<char,
std::__1::char_traits<char> >'
return ParseFromZeroCopyStream(&zero_copy_input) && input->eof();
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/iosfwd:108:28:
note:
template is declared here
class _LIBCPP_TYPE_VIS basic_istream;
^
google/protobuf/message.cc:135:67: error: implicit instantiation of
undefined template 'std::__1::basic_istream<char,
std::__1::char_traits<char> >'
return ParsePartialFromZeroCopyStream(&zero_copy_input) && input->eof();
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/iosfwd:108:28:
note:
template is declared here
class _LIBCPP_TYPE_VIS basic_istream;
^
google/protobuf/message.cc:175:16: error: implicit instantiation of
undefined template 'std::__1::basic_ostream<char,
std::__1::char_traits<char> >'
return output->good();
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/iosfwd:110:28:
note:
template is declared here
class _LIBCPP_TYPE_VIS basic_ostream;
^
3 errors generated.
make[2]: *** [message.lo] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Please use labels and text to provide additional information.



--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[prot...@googlecode.com]

Comment #1 on issue 570 by mail.lus...@gmail.com: build 2.4.1 failed on mac

os x 10.9
http://code.google.com/p/protobuf/issues/detail?id=570

I think the right way to fix it is to modify the message.h like below
#ifdef __DECCXX
// HP C++'s iosfwd doesn't work.
#include <iostream>
#else
#include <sstream>
//#include <iosfwd>
#endif

[prot...@googlecode.com]

Comment #2 on issue 570 by pr8...@gmail.com: build 2.4.1 failed on mac os x
10.9
http://code.google.com/p/protobuf/issues/detail?id=570

fix proposed in comment #1 worked for me.

[prot...@googlecode.com]

Comment #3 on issue 570 by zkb...@gmail.com: build 2.4.1 failed on mac os x
10.9
http://code.google.com/p/protobuf/issues/detail?id=570

thanks, i fix it as comment #1

[prot...@googlecode.com]

Comment #4 on issue 570 by hzwangxi...@gmail.com: build 2.4.1 failed on mac

os x 10.9
http://code.google.com/p/protobuf/issues/detail?id=570

Thanks, comment #1 is OK !

[prot...@googlecode.com]

Comment #5 on issue 570 by issam.n...@gmail.com: build 2.4.1 failed on mac

os x 10.9
http://code.google.com/p/protobuf/issues/detail?id=570

comment #1 is OK , tx

[prot...@googlecode.com]

Comment #6 on issue 570 by lukemewb...@gmail.com: build 2.4.1 failed on mac

os x 10.9
http://code.google.com/p/protobuf/issues/detail?id=570

I think that this issue is just a variation of the issue reported in issue
455.

Adding #include <istream> to src/google/protobuf/message.cc fixes this
problem, as per the latest version of that file in svn.

[prot...@googlecode.com]

Comment #7 on issue 570 by getae...@gmail.com: build 2.4.1 failed on mac os
x 10.9
http://code.google.com/p/protobuf/issues/detail?id=570

"Adding #include <istream>" solution worked for me

[prot...@googlecode.com]

Comment #8 on issue 570 by msaf...@gmail.com: build 2.4.1 failed on mac os
x 10.9
http://code.google.com/p/protobuf/issues/detail?id=570

Adding #include <istream> worked for me as well.

[prot...@googlecode.com]

Comment #9 on issue 570 by Azxf...@gmail.com: build 2.4.1 failed on mac os
x 10.9
https://code.google.com/p/protobuf/issues/detail?id=570

it the cofing.h file

[prot...@googlecode.com]

Comment #10 on issue 570 by zhen...@ayasdi.com: build 2.4.1 failed on mac

os x 10.9
https://code.google.com/p/protobuf/issues/detail?id=570

Adding #include <istream> isn't working for me. What's the change to the
config.h?

[prot...@googlecode.com]

Updates:
Status: Fixed

Comment #11 on issue 570 by xiaof...@google.com: build 2.4.1 failed on mac

os x 10.9
https://code.google.com/p/protobuf/issues/detail?id=570

The latest code includes <iostream> which I believe has fixed this issue:
https://github.com/google/protobuf/blob/master/src/google/protobuf/message.cc

[Rajashekhar Choukimath]

This fixed the issue

_____________________________________________________________

The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.