Issue 422 in protobuf: DLL libprotobuf-lite missing StringSpaceUsedExcludingSelf implementation

[prot...@googlecode.com]

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 422 by driveha...@gmail.com: DLL libprotobuf-lite missing
StringSpaceUsedExcludingSelf implementation
http://code.google.com/p/protobuf/issues/detail?id=422

What steps will reproduce the problem?
1. Follow steps in vsprojects/readme.txt for configuring libprotobuf-lite
to be built as a DLL
2. Build libprotobuf-lite under msvc 2008
3.

What is the expected output? What do you see instead?
Expected output is that the linker succeeds in creating the DLL.
Observed output:
1>extension_set.obj : error LNK2019: unresolved external symbol "int
__cdecl google::protobuf::internal::StringSpaceUsedExcludingSelf(class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &)"
(?StringSpaceUsedExcludingSelf@internal@protobuf@google@@YAHABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
referenced in function "public: static int __cdecl
google::protobuf::internal::StringTypeHandler::SpaceUsed(class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &)"
(?SpaceUsed@StringTypeHandler@internal@protobuf@google@@SAHABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
1>repeated_field.obj : error LNK2001: unresolved external symbol "int
__cdecl google::protobuf::internal::StringSpaceUsedExcludingSelf(class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &)"
(?StringSpaceUsedExcludingSelf@internal@protobuf@google@@YAHABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
1>wire_format_lite.obj : error LNK2001: unresolved external symbol "int
__cdecl google::protobuf::internal::StringSpaceUsedExcludingSelf(class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &)"
(?StringSpaceUsedExcludingSelf@internal@protobuf@google@@YAHABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
1>Debug\libprotobuf-lite.dll : fatal error LNK1120: 1 unresolved externals

What version of the product are you using? On what operating system?
protobuf 2.4.1
Windows 7
MSVC 2008

Please provide any additional information below.
This appears to be implemented in the full libprotobuf, the lite version
does not seem to have the definition available for the linker.

[prot...@googlecode.com]

Comment #1 on issue 422 by driveha...@gmail.com: DLL libprotobuf-lite

missing StringSpaceUsedExcludingSelf implementation
http://code.google.com/p/protobuf/issues/detail?id=422

This apparently is only under Debug, building under Release this will work
correctly.

[prot...@googlecode.com]

Updates:
Owner: xiaof...@google.com

Comment #2 on issue 422 by liuj...@google.com: DLL libprotobuf-lite missing
StringSpaceUsedExcludingSelf implementation
http://code.google.com/p/protobuf/issues/detail?id=422

(No comment was entered for this change.)

[prot...@googlecode.com]

Comment #3 on issue 422 by driveha...@gmail.com: DLL libprotobuf-lite

missing StringSpaceUsedExcludingSelf implementation
http://code.google.com/p/protobuf/issues/detail?id=422

After looking more closely this appears to have been fixed in r401 already.
Is there a patch planned for the 2.4 series?

[prot...@googlecode.com]

Updates:
Status: Fixed

Comment #4 on issue 422 by xiaof...@google.com: DLL libprotobuf-lite

missing StringSpaceUsedExcludingSelf implementation
http://code.google.com/p/protobuf/issues/detail?id=422

It will be included in 2.5.0 release.