Issue 531 in protobuf: Cannot build protobuf using VS2013

[prot...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 531 by makoto...@gmail.com: Cannot build protobuf using VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

What steps will reproduce the problem?
1. Build protobuf project via Visual Studio 2013 Preview

- Result
1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(66): error
C3861: 'min': identifier not found
1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(119): error
C3861: 'min': identifier not found
1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(166): error
C3861: 'max': identifier not found
1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(193): error
C3861: 'min': identifier not found


What is the expected output? What do you see instead?
No error

Please use labels and text to provide additional information.


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[prot...@googlecode.com]

Comment #1 on issue 531 by makoto...@gmail.com: Cannot build protobuf using
VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

A patch to fix

Attachments:
vs2013.patch 362 bytes

[prot...@googlecode.com]

Comment #2 on issue 531 by mjk...@gmail.com: Cannot build protobuf using
VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

Just tried VS2013, this patch works for me too. It should work in VS2012
too and previous versions. I will post here again if I find a problem with
other compilers.

[prot...@googlecode.com]

Comment #3 on issue 531 by vvnicho...@gmail.com: Cannot build protobuf
using VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

That's not the only issue with VS2013. I get the following error:

..\src\google\protobuf\io\zero_copy_stream.cc : fatal error C1041: cannot
open program
database 'e:\downloads\protobuf-2.5.0\vsprojects\release\vc120.pdb'; if
multiple CL.EXE write to the same .PDB file, please use /FS

Repeated for a number of other files.

[prot...@googlecode.com]

Comment #4 on issue 531 by mjk...@gmail.com: Cannot build protobuf using
VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

@vvnicho It's a Protobuf problem, you have multiple process opening the
same pdb...

[prot...@googlecode.com]

Comment #5 on issue 531 by vvnicho...@gmail.com: Cannot build protobuf
using VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

@mjklaim Yes, it's a problem with Protobuf's project files, and it can be
fixed by adding the /FS switch.

[prot...@googlecode.com]

Comment #6 on issue 531 by sorin.sb...@gmail.com: Cannot build protobuf
using VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

What a surprise: I downloaded latest release of libproto (2.5) and tried to
convert the projects to 2013 and surprise, msdev 2013 gets stuck at
Migrating 5 of 9: gtest.

Compiling boost trunk worked with msdev-2013 :p

[prot...@googlecode.com]

Comment #7 on issue 531 by makoto...@gmail.com: Cannot build protobuf using
VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

This seems to be fixed by r512
(http://code.google.com/p/protobuf/source/detail?r=512). please close this.

[prot...@googlecode.com]

Updates:
Status: Fixed

Comment #8 on issue 531 by xiaof...@google.com: Cannot build protobuf using
VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

(No comment was entered for this change.)

[prot...@googlecode.com]

Comment #9 on issue 531 by xiaof...@google.com: Cannot build protobuf using
VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

Issue 616 has been merged into this issue.

[prot...@googlecode.com]

Comment #10 on issue 531 by jie...@google.com: Cannot build protobuf using
VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

Issue 635 has been merged into this issue.

[prot...@googlecode.com]

Comment #11 on issue 531 by jie...@google.com: Cannot build protobuf using

[prot...@googlecode.com]

Comment #13 on issue 531 by novede...@gmail.com: Cannot build protobuf
using VS2013
http://code.google.com/p/protobuf/issues/detail?id=531

I've run into the same problems described, both the /FS switch and the
min/max error and have fixed both.

However I've come across a third error:
error MSB6006: "cmd.exe" exited with code 3.

I'm using visual studio 2013 express and protobuf 2.5. Trying to write out
release X64. It seems to work with release win32.

[elodg]

I got the same error when building for x64. The custom build command for proto files in the test projects are hard-coded to work with the default intermediate build directory in the Win32 configuration. You need to change the command property of the Custom Build Tool for all the proto files to something like:
$(OutDir)protoc -I..\src --cpp_out=. %(Identity)

Elod

[prot...@googlecode.com]

Comment #14 on issue 531 by st.ere...@gmail.com: Cannot build protobuf
using VS2013
https://code.google.com/p/protobuf/issues/detail?id=531

Same problem as #12