Donating ProtoDomain and ProtoLanguageFileWriter to protobuf-java

56 views
Skip to first unread message

Alex Van Boxel

unread,
Feb 21, 2020, 7:41:42 AM2/21/20
to Protocol Buffers
Hi all,

I have 2 utility classes for the Java implementation I like to donate to the java implementation:


I've been using it into our protobuf schema registry but they stand on it's own:

ProtoDomain:
  • wrapper around FileDescriptorSet that makes it Java serializable. The serialization is for use mainly used to serialize it in the Protobuf extension to Apache Beam.
  • index into the FileDescriptorSet, makes the set searchable and get Descriptors and other entries out of the set easily
ProtoLanguageFileWriter:
  • this can be used to write out textual versions of a binary FileDescriptorSet. This is proven very useful in our registry as we're creating dynamic descriptors, but we want to track the changes in git. This class only writes out a set in a directory and it can be very useful.
Is this interesting to be part of the java implementation? I think so, but what do the main maintainers think?

The protobuf registry I like to donate as well, but I think this would be better housed in the grpc-ecosystem... (but that's another discussion)

ittai zeidman

unread,
Feb 21, 2020, 8:42:58 AM2/21/20
to Protocol Buffers
I’d like to add a +1 to that.
I have a need to write out textual proto files (I’m essentially transpiling proto files) and I looked for such utilities inside protobuf-java and couldn’t find them.

Robert Sahlin

unread,
Mar 2, 2020, 5:28:05 AM3/2/20
to Protocol Buffers
Thanks Alex, that would be generous of you and most useful.

itt...@gmail.com

unread,
Jun 14, 2020, 12:06:41 PM6/14/20
to Protocol Buffers
Hi,
Did this advance?

Reply all
Reply to author
Forward
0 new messages