Issue 446 in protobuf: Fix unused parameter warnings

[prot...@googlecode.com]

Status: New
Owner: liu...@google.com
Labels: Type-Defect Priority-Medium

New issue 446 by muka...@gmail.com: Fix unused parameter warnings
http://code.google.com/p/protobuf/issues/detail?id=446

What steps will reproduce the problem?
1. Build generated code with -Werror,-Wunused-parameter

What is the expected output? What do you see instead?
In file included from monitor/head/protobuf/Stream.pb.h:23:
protobuf/head/target/include/google/protobuf/repeated_field.h:1197:54:
error: unused parameter
'ignores_parameter' [-Werror,-Wunused-parameter]
RepeatedFieldBackInsertIterator<T>& operator++(int ignores_parameter) {
^
protobuf/head/target/include/google/protobuf/repeated_field.h:1228:57:
error: unused parameter
'ignores_parameter' [-Werror,-Wunused-parameter]
RepeatedPtrFieldBackInsertIterator<T>& operator++(int ignores_parameter) {
^
protobuf/head/target/include/google/protobuf/repeated_field.h:1257:11:
error: unused parameter
'ignores_parameter' [-Werror,-Wunused-parameter]
int ignores_parameter) {
^

What version of the product are you using? On what operating system?
protobuf-2.4.1
Mac OS X 10.8.2
Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn)

Please provide any additional information below.
Proposed patch attached.

Attachments:
unused_parameter.patch- 0 bytes

[prot...@googlecode.com]

Comment #2 on issue 446 by muka...@gmail.com: Fix unused parameter warnings
http://code.google.com/p/protobuf/issues/detail?id=446

Let's try this again.

Attachments:
unused_parameter.patch 1.0 KB

[prot...@googlecode.com]

Comment #1 on issue 446 by liu...@google.com: Fix unused parameter warnings
http://code.google.com/p/protobuf/issues/detail?id=446

The patch is empty.

[prot...@googlecode.com]

Updates:
Status: Invalid

Comment #3 on issue 446 by liu...@google.com: Fix unused parameter warnings
http://code.google.com/p/protobuf/issues/detail?id=446

Those are already fixed in 2.5.0