js/binary/encoder.js missing from protobuf-js-3.0.0-alpha-6.zip

20 views
Skip to first unread message

Hochhaus, Andy

unread,
May 22, 2016, 9:57:05 PM5/22/16
to Protocol Buffers
Hi,

I noticed that encoder.js is missing from protobuf-js-3.0.0-alpha-6.zip.

$ grep -r "'jspb.BinaryEncoder'" protobuf-3.0.0-alpha-6/
protobuf-3.0.0-alpha-6/js/binary/writer.js:goog.require('jspb.BinaryEncoder');
protobuf-3.0.0-alpha-6/js/binary/decoder_test.js:goog.require('jspb.BinaryEncoder');

This isn't a big deal since the file is available from github. Could
this be fixed for the next beta (alpha?) release?

-Andy

Hochhaus, Andy

unread,
May 23, 2016, 12:48:08 AM5/23/16
to Protocol Buffers
I realized that the release archives are generated from "make dist" so
I sent a PR for this issue.

https://github.com/google/protobuf/pull/1589

Sorry for the noise.

-Andy
Reply all
Reply to author
Forward
0 new messages