Issue 237 in protobuf-dt: Does not handle spaces in Windows-style Path correctly

[proto...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 237 by sascha.t...@gmail.com: Does not handle spaces in
Windows-style Path correctly
http://code.google.com/p/protobuf-dt/issues/detail?id=237

What steps will reproduce the problem?
1. Create .proto file in a path where at least one folder has a space in
its name.
2. Save .proto file

What is the expected output? What do you see instead?
I see:
[command] protoc --proto_path=C:\Users\myusername\My Stuff\restofpath\src
--java_out=C:\Users\myusername\My Stuff\restofpath\src
C:\Users\myusername\My Stuff\restofpath\FileName.proto
[protoc] C:\Users\myusername\My: warning: directory does not exist.
[protoc] Stuff\restofpath\src: No such file or directory

I expect:
Well, a proper compilation of course. This might work:
[command] protoc --proto_path="C:\Users\myusername\My Stuff\restofpath\src"
--java_out="C:\Users\myusername\My
Stuff\restofpath\src" "C:\Users\myusername\My
Stuff\restofpath\FileName.proto"

What version of the product are you using? On what operating system?
Eclipse 3.7.1
protobuf-dt 1.3.3
Windows 7 64bit

Please provide any additional information below.

[proto...@googlecode.com]

Comment #1 on issue 237 by stev...@gmail.com: Does not handle spaces in

Windows-style Path correctly
http://code.google.com/p/protobuf-dt/issues/detail?id=237

Seems really simple to just fix the issue by quoting the paths. This is
really really annoying.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[proto...@googlecode.com]

Comment #2 on issue 237 by hunters...@gmail.com: Does not handle spaces in

Windows-style Path correctly
http://code.google.com/p/protobuf-dt/issues/detail?id=237

A simple patch to test if a path contains a string and place a char '\"'
around the path, or leave it alone if it does not. Fixed for both path of
protoc[.exe] and the options for java, c++, python outputs and the
descriptor.proto path.

patch is from git head c9d6ac6a63312fcaa72895cc2b34fb2f9187342a

Attachments:
protobuf-dt.patch 2.2 KB