[PATCH] mod_http: Catch errors when parsing IP from X-Forwarded-For

8 views
Skip to first unread message

Boris Grozev

unread,
Oct 27, 2023, 12:57:48 PM10/27/23
to proso...@googlegroups.com
Hello,

A small fix to prevent throwing an exception when the X-Forwarded-For
header includes invalid values. Repro with just
curl $BOSH_URL -X POST -H "X-Forwarded-For: something-invalid"

Oct 27 16:55:32 http.server error Traceback[httpserver]:
/usr/share/lua/5.2/prosody/util/ip.lua:233: attempt to index local
'ipA' (a nil value)
stack traceback:
/usr/share/lua/5.2/prosody/util/ip.lua:233: in function 'match_ip'
/usr/lib/prosody/modules/mod_http.lua:297: in function 'is_trusted_proxy'
/usr/lib/prosody/modules/mod_http.lua:319: in function
'get_forwarded_connection_info'
/usr/lib/prosody/modules/mod_http.lua:334: in function
</usr/lib/prosody/modules/mod_http.lua:330>


Regards,
Boris
catch-ip-parse-errors.patch
Reply all
Reply to author
Forward
0 new messages