[PATCH] mod_auth_internal_plain: Fix user creation done via mod_admin_shell

[vkvo...@vivaldi.net]

Following the behavior in auth_internal_hashed, the account will be created and
disabled, instead of returning an error telling password being nil when calling
saslprep().

[Matthew Wild]

Hi,

Thanks for the patch! I've merged it with a couple of tweaks (if you
pull and evolve, it should fix any conflicts between your patch and my
changes).

- I added a reference in the commit message to the specific commit
where mod_admin_shell's behaviour changed (e.g. so it's easy to
discover exacly when the bug was introduced)
- I noted in the message that mod_auth_internal_plain doesn't actually
fully support "disabled" accounts currently
- I fixed some minor style things - we generally only use semicolons
as separators when they are at the end of a line

Congrats on your first merged contribution :)

Regards,
Matthew

[Vitaly Orekhov]

Thanks, Matt!

Regarding incomplete support of enabling and disabling accounts, I was going to submit another patch that adds the missing functions right after I pushed this one, but I needed to have some sleep. :)

The patch to add them will be ready in next hour or so.

[Vitaly Orekhov]

[PATCH] mod_auth_internal_plain: Add functions to enable/disable/check
user activation

Followup to 2cb5994e3f94. Implementaion taken from auth_internal_hashed
is fully
compatible with plain one.

[Vitaly Orekhov]

[PATCH] mod_auth_internal_plain: Add functions to enable/disable/check user activation

Can this patch get merged into trunk? It's still hanging as a draft in contrib.

[Vitaly Orekhov]

Any updates on this one, please? Just in case, it's changeset 29ca2aa9d552 in contrib, still there as a draft.

[Vitaly Orekhov]

Rebased on top of contrib as changeset 4e125f96b264.

В 10 март 2026 г. 23:08:40 (+03:00), 'Vitaly Orekhov' via prosody-dev пишет:

-- 
---
Vitaly A. Orekhov