[patch] Optimize stanza cloning in case of broadcast_roles setting

[Damian Minkov]

While testing big conferences and observing and profiling prosody we noticed(thanks to Boris Grozev) that some presences are created and not sent to participants which drastically increased CPU usage for 2000 participants in a room. This is a case with a large room with mostly occupants with a role 'visitor'.

A possible fix in muc/muc.lib.lua:

342c342

< if filter == nil or filter(occupant_jid, occupant) then

---

> if (filter == nil or filter(occupant_jid, occupant)) and (to_bare == occupant.bare_jid or broadcast_roles[occupant.role or "none"]) then

349,351c349

< if to_bare == occupant.bare_jid or broadcast_roles[occupant.role or "none"] then

< self:route_stanza(pres);

< end

---

> self:route_stanza(pres);

We tested this change which reduced the CPU by more than 60% in that test case.

The following change was not tested but seems reasonable as unnecessary clones of stanzas are created.

307d306

< local pr = get_p(n_occupant);

309c308

< self:route_to_occupant(n_occupant, pr);

---

> self:route_to_occupant(n_occupant, get_p(n_occupant));

310a310

> local pr = get_p(n_occupant);

Thank you

damencho

[Damian Minkov]

Hi again,

What do you think about this?

Regards

damencho

[Damian Minkov]

Hi again,

What about this one, can this optimization be included in the next 0.12 release? 

We have been running it for a while on meet.jit.si

https://github.com/jitsi/infra-configuration/blob/061508f9a8736169d73e76b824e101de40d03da1/ansible/roles/prosody/files/muc_lib_visitor_broadcast.patch

Thank you

damencho

[Matthew Wild]

On Sat, 18 Feb 2023 at 17:32, Damian Minkov <dame...@damencho.com> wrote:
> What about this one, can this optimization be included in the next 0.12 release?
> We have been running it for a while on meet.jit.si
> https://github.com/jitsi/infra-configuration/blob/061508f9a8736169d73e76b824e101de40d03da1/ansible/roles/prosody/files/muc_lib_visitor_broadcast.patch

Thanks for the patch. As the 0.12.3 release is already behind
schedule, I won't have time to review this patch for inclusion.
However I will work on getting it reviewed and merged soon after the
release.

Sorry for the wait!

Regards,
Matthew

[Damian Minkov]

Hey Matthew,

Did this manage to go into 0.12.4 as I don't see it?

Thanks

damencho

--
You received this message because you are subscribed to the Google Groups "prosody-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prosody-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prosody-dev/CAJt9-x6qvNutWnvECZCKtQ5RFO90YwtN71mZF34%3D4je62qdVPA%40mail.gmail.com.

[Damian Minkov]

Bump :) 

Can you take a look?

Thanks

[Matthew Wild]

Hi Damien,

On Thu, 14 Nov 2024 at 22:08, 'Damian Minkov' via prosody-dev
<proso...@googlegroups.com> wrote:
>
> Bump :)
>
> Can you take a look?

Thanks for the nudge, and sorry it took a while. The patch is now
merged into 0.12 and trunk as
https://hg.prosody.im/trunk/rev/eedae7d47784 - it will be in the next
releases which are due "soon" :)

Regards,
Matthew