Automate lint and format in prometheus/client_python
27 views
Skip to first unread message
yzdann mohammadi
Oct 2, 2020, 5:35:00 AM10/2/20
to Prometheus Developers
Hi
I run `tox -e flake8` in the client_python master branch and got failed tests.
I think it's a good idea to add pre-commit or even add linting as part of CI to this project to prevent this kind of issues
I run `tox -e flake8` in the client_python master branch and got failed tests.
I think it's a good idea to add pre-commit or even add linting as part of CI to this project to prevent this kind of issues
If it's helpful let me know and i will work on it.
Brian Brazil
Oct 2, 2020, 6:15:26 AM10/2/20
to yzdann mohammadi, Prometheus Developers
Sure, send on a PR.
Brian
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/1302b4ca-394e-4781-a472-69acd6f59b90n%40googlegroups.com.
Brian Brazil
Julien Pivotto
Oct 2, 2020, 6:54:37 AM10/2/20
to Brian Brazil, yzdann mohammadi, Prometheus Developers
On 02 Oct 11:15, Brian Brazil wrote:
> On Fri, 2 Oct 2020 at 10:35, yzdann mohammadi <yzd...@gmail.com> wrote:
>
> > Hi
> > I run `tox -e flake8` in the client_python master branch and got failed
> > tests.
> > I think it's a good idea to add pre-commit or even add linting as part of
> > CI to this project to prevent this kind of issues
> > If it's helpful let me know and i will work on it.
> >
>
> Sure, send on a PR.
In general I think that CI is better than forcing people to run scripts
> On Fri, 2 Oct 2020 at 10:35, yzdann mohammadi <yzd...@gmail.com> wrote:
>
> > Hi
> > I run `tox -e flake8` in the client_python master branch and got failed
> > tests.
> > I think it's a good idea to add pre-commit or even add linting as part of
> > CI to this project to prevent this kind of issues
> > If it's helpful let me know and i will work on it.
> >
>
> Sure, send on a PR.
as part of pre-commit.
>
> Brian
>
>
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Prometheus Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to prometheus-devel...@googlegroups.com.
> > To view this discussion on the web visit
> > https://groups.google.com/d/msgid/prometheus-developers/1302b4ca-394e-4781-a472-69acd6f59b90n%40googlegroups.com
> > .
> >
>
>
> --
> Brian Brazil
> www.robustperception.io
>
> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLpV-AVmNduMKyGdOcvwxxxn47rJHQrEbdSsdf9G3t3SaQ%40mail.gmail.com.
> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
--
Julien Pivotto
@roidelapluie
yzdann mohammadi
Oct 2, 2020, 7:15:55 AM10/2/20
to Prometheus Developers
Thank you both
I will add that check to CI and then send a PR.
Reply all
Reply to author
Forward
0 new messages