New labels in prometheus/prometheus

[Julien Pivotto]

Hi,

I'd like to add two new labels to prometheus/prometheus repository:

"kind/new-sd"
for new service discoveries requests
"bug scrub"
for issues we want to have parsed at the bug scrubs. Not
new ones, but old ones that have been somehow updated or that need to be
revisited.

What do you think?

Thanks!

--
Julien Pivotto
@roidelapluie

[Brian Brazil]

On Thu, 10 Sep 2020 at 23:14, Julien Pivotto <roidel...@prometheus.io> wrote:

Hi,

I'd like to add two new labels to prometheus/prometheus repository:

"kind/new-sd"
    for new service discoveries requests

I think the existing service discovery label is sufficient, I'd rather not have overly granular definitions. For these issues it's generally obvious from the title what it is.

 

"bug scrub"
    for issues we want to have parsed at the bug scrubs. Not
    new ones, but old ones that have been somehow updated or that need to be
    revisited.

How would this work? Bug scrubs are largely about going through issues that haven't been updated in a while, so if there's been a recent update then there's likely not to be much to do.

Brian

 

What do you think?

Thanks!

--
Julien Pivotto
@roidelapluie

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200910221411.GA1303975%40oxygen.

--

Brian Brazil

www.robustperception.io

[Ben Kochie]

On Fri, Sep 11, 2020 at 1:49 AM Brian Brazil <brian....@robustperception.io> wrote:

On Thu, 10 Sep 2020 at 23:14, Julien Pivotto <roidel...@prometheus.io> wrote:

Hi,

I'd like to add two new labels to prometheus/prometheus repository:

"kind/new-sd"
    for new service discoveries requests

I think the existing service discovery label is sufficient, I'd rather not have overly granular definitions. For these issues it's generally obvious from the title what it is.

Titles are not good for label-based filtering. But I also think kind/new-sd isn't right either. It's mixing "kind" and "component".

I would label a new service discovery with a pair of labels: component/service-discovery + kind/feature

 

 

"bug scrub"
    for issues we want to have parsed at the bug scrubs. Not
    new ones, but old ones that have been somehow updated or that need to be
    revisited.

How would this work? Bug scrubs are largely about going through issues that haven't been updated in a while, so if there's been a recent update then there's likely not to be much to do.

Brian

 

What do you think?

Thanks!

--
Julien Pivotto
@roidelapluie

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200910221411.GA1303975%40oxygen.

--

Brian Brazil

www.robustperception.io

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLonBdAedbAyMFDB3pmR0rQWyPZ1jKd9aYr9P1P_UH2buQ%40mail.gmail.com.

[Julien Pivotto]

On 11 Sep 00:48, Brian Brazil wrote:
> On Thu, 10 Sep 2020 at 23:14, Julien Pivotto <roidel...@prometheus.io>
> wrote:
> > "bug scrub"
> > for issues we want to have parsed at the bug scrubs. Not
> > new ones, but old ones that have been somehow updated or that need to
> > be
> > revisited.
> >
>
> How would this work? Bug scrubs are largely about going through issues that
> haven't been updated in a while, so if there's been a recent update then
> there's likely not to be much to do.

Yeah the point is when there is updates when should the bug scrub revisit
them? Do we need to wait for a complete loop of all the issues?
When it is easy we can respond individually, otherwise it is more
difficult, and the voice of the scrub would be more appropriate.

There are also issues skipped that we might want to get back to, and
"free" them to they can be tackled by people still active. Should that
wait another round of bug scrub too?

>
> Brian
>
>
> >
> > What do you think?
> >
> > Thanks!
> >
> > --
> > Julien Pivotto
> > @roidelapluie
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Prometheus Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to prometheus-devel...@googlegroups.com.
> > To view this discussion on the web visit
> > https://groups.google.com/d/msgid/prometheus-developers/20200910221411.GA1303975%40oxygen
> > .
> >
>
>
> --
> Brian Brazil
> www.robustperception.io
>
> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLonBdAedbAyMFDB3pmR0rQWyPZ1jKd9aYr9P1P_UH2buQ%40mail.gmail.com.

--
Julien Pivotto
@roidelapluie

[Julien Pivotto]

On 11 Sep 08:16, Ben Kochie wrote:
> Titles are not good for label-based filtering. But I also think kind/new-sd
> isn't right either. It's mixing "kind" and "component".
>
> I would label a new service discovery with a pair of labels:
> component/service-discovery + kind/feature

Thanks

I have updated a few new SD requests issues to uses those labels.

> > <https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLonBdAedbAyMFDB3pmR0rQWyPZ1jKd9aYr9P1P_UH2buQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
> > .

> >
>
> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CABbyFmoq0Z0mJ0U%2BhPusk%2BRdr7zkacmxD0DkA8CuPPuRt%3DYkFg%40mail.gmail.com.

--
Julien Pivotto
@roidelapluie