Thanks for doing this.
Beyond benchmarks, two general concerns:
- How unsafe is `enableunsafedecode=true`? I spot-checked the csproto
code, and the risk seems to be on the side of the user code,
i.e. luckily there isn't any unsafe input, but I'm wondering how
easily we'll introduce bugs in that way. What's the gain by using
the flag vs. not using it? (FTR, the Prometheus code is using the
same trick with the `yoloString` itself, but that has also been
frowned upon...)
- How confident can we be that csproto will be consistently
maintained? It seems to be mostly the work of a single person, and
it is sponsored by a single company (which is at least already 13
years around, and has 7k employees, so probably not disappearing
tomorrow).
Not saying these are blockers, just trying to come to an informed
decision.
--
Björn Rabenstein
[PGP-ID] 0x851C3DA17D748D03
[email]
bjo...@rabenste.in