Pass additional version to docker file

31 views

Skip to first unread message

Assaf Katz

unread,

Feb 3, 2021, 5:49:48 AM2/3/21

to Prometheus Developers

Hi,

Currently there is no option to find out from docker manifest what is the version which it was built for. Therefore I created pull request (https://github.com/prometheus/prometheus/pull/8435) to introduce this option. This will allow us to add version label to each image.

The change is small. Makefile.common already relies on VERSION file to calculate DOCKER_MAJOR_VERSION_TAG variable so there is no additional dependency. This change will introduce new warning until the docker files will be changed: '[Warning] One or more build-args [VERSION] were not consumed' but no new errors.

Thanks,

Assaf Katz

unread,

Feb 16, 2021, 5:51:08 AM2/16/21

to Prometheus Developers

Hi,

I added more explanation to pull request, but it is stuck since nobody answer. about them

Thanks,

Assaf

ב-יום רביעי, 3 בפברואר 2021 בשעה 12:49:48 UTC+2, Assaf Katz כתב/ה:

Reply all

Reply to author

Forward

0 new messages