Looks quite good. Thanks for the work done.
Some nits:
Port 9114 is already used by the Elasticsearch exporter. See
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
(the list might not be up to date – we should probably check it
against
http://prometheus.io/docs/instrumenting/exporters/ ).
The naming convention for counters is to always end on `_total`. Some
of your counters have the `total` in the middle, some have none at
all.
Exporting rates directly ("something per second") is rather
"un-Promethean". It is preferred to export a counter of "something"
and let the Prometheus server calculate a rate. (In that way, you
don't lose data but only resolution if you miss a scrape.) mod_status
is exporting rates because not everybody has Prometheus. :) If I
understand the mod_status output correctly, `ReqPerSec` is just a rate
of `Total Accesses`. Correspondingly, `BytesPerSec` is a rate of
`Total kBytes`, and `BytesPerReq` is the ratio of `BytesPerSec` and
`ReqPerSec`. All of these calculations can be done by Prometheus, so
arguably, you should not export `ReqPerSec`, `BytesPerSec` and
`BytesPerReq` at all.
> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to
prometheus-devel...@googlegroups.com.
> For more options, visit
https://groups.google.com/d/optout.
--
Björn Rabenstein, Engineer
http://soundcloud.com/brabenstein
SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany
Managing Director: Alexander Ljung | Incorporated in England & Wales
with Company No. 6343600 | Local Branch Office | AG Charlottenburg |
HRB 110657B