Add additional docker file

35 views
Skip to first unread message

Assaf Katz

unread,
Jan 28, 2021, 9:10:53 AM1/28/21
to Prometheus Developers

Hi,

I have requirement to get only certified RedHat container images and some of docker images in stack aren't available. Therefore, I want to create additional docker file for these images (for example, push gateway). My concern is how should I integrate this new docker file with Prometheus build system.

As far as I understand, there is Makefile.common that should be changed, but I am less sure what exactly I should change there and want to be sure before I start. Per my understanding, this requires duplicate the code of common-docker, common-docker-publish, common-docker-tag-latest and common-docker-manifest with wrapping the new code with if statement about existing of Dockerfile.ubi.

Thanks,

Assaf

Bartłomiej Płotka

unread,
Jan 28, 2021, 3:29:37 PM1/28/21
to Assaf Katz, Prometheus Developers
Hi,

Can you check if what we actively maintain in https://github.com/openshift/prometheus downstream (we have automation for those things) works for you? We have this downstream fork literally to build Red Hat certified docker images. Maybe you will find this helpful (: 

Kind Regards,
Bartek Płotka (@bwplotka)


--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/62fd2319-5c56-4957-898b-13d2b446b89an%40googlegroups.com.

Assaf Katz

unread,
Jan 31, 2021, 1:04:29 AM1/31/21
to Prometheus Developers
Hi,
I know the location that you, but it contains only Prometheus itself, the other parts that need and specially pushgateway, which isn't there or in RedHat catalog. In additional, it seems that the build system is different - using prom instead CircleCI.
Thanks

ב-יום חמישי, 28 בינואר 2021 בשעה 22:29:37 UTC+2, bwpl...@gmail.com כתב/ה:

Assaf Katz

unread,
Jan 31, 2021, 6:57:38 AM1/31/21
to Prometheus Developers
Oops, typos:
I know the location that you mentioned, but it contains only Prometheus itself, the other parts that need and specially pushgateway, which isn't there or in RedHat catalog. In additional, it seems that the build system is different - using prow instead CircleCI.

ב-יום ראשון, 31 בינואר 2021 בשעה 08:04:29 UTC+2, ‪Assaf Katz‬‏ כתב/ה:
Reply all
Reply to author
Forward
0 new messages