Mirroring lezer-promql

[Augustin Husson]

Hello Prometheans,

As you may know, one month ago we moved the code living in codemirror-promql directly to Prometheus.

This move was made to avoid a desync between any changes performed in the PromQL language and the PromQL editor.

A side effect of this move is that we also integrated what we called `lezer-promql` directly in Prometheus.

lezer-promql is a repository that contains the PromQL grammar in the javascript world. And at this time, we (Julius and I) decided to put this repository as deprecated and not maintained. It was based on the assumption that lezer-promql wasn't used without codemirror.

Our friends from Grafana proved us we were wrong since they are using lezer-promql today directly without using codemirror.

In order to re-enable the repository lezer-promql, I'm proposing to make a mirror of it, like we did for codemirror-promql. That shouldn't be a big issue, we just need to add a new (tiny) script of sync like it exists to synchronize codemirror-promql.

Another thing we will have to do, is to move the repository lezer-promql from PromLabs to Prometheus. 

With Julius we assumed it makes sense to move it to the Prometheus org as it is now officially part of Prometheus.

To be consistent, we should also move the repository codemirror-promql to the Prometheus organization as well.

So to summarize, what I am asking is :

1. Do you agree to move codemirror-promql and lezer-promql to the Prometheus org ?

2. Do you agree to mirror the repo lezer-promql with the code living in Prometheus ?

Cheers,

Augustin.

[Julien Pivotto]

1 yes

2 yes

[Julius Volz]

Yes on both counts as well from me :)

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/5fa0c5a1-0fea-4030-b3a6-77780bab1bb9n%40googlegroups.com.

[Augustin Husson]

cool ! Many thanks for your answers :).

I will do the required changes then.

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yoy%3DWkj0FG3VFLNWxPatu_-cDEOGrmaG3Noj0Vz7TNia%2BA%40mail.gmail.com.