Library for collecting application metrics in .NET and exporting them to Prometheus

85 views
Skip to first unread message

Mark Farkas

unread,
Sep 21, 2017, 8:05:22 PM9/21/17
to Prometheus Developers
Hi!

We have created an open-source library at my company for collecting application metrics in .NET.

Do you think it would be worth to take a look and refer it somewhere in the Prometheus documentation?

Looking forward to your kind reply and feedbacks!
Cheers,

Mark

Brian Brazil

unread,
Sep 22, 2017, 3:02:11 AM9/22/17
to Mark Farkas, Prometheus Developers
On 22 September 2017 at 01:05, Mark Farkas <farka...@gmail.com> wrote:
Hi!

We have created an open-source library at my company for collecting application metrics in .NET.

Do you think it would be worth to take a look and refer it somewhere in the Prometheus documentation?

Thanks for sharing. We already list https://github.com/andrasm/prometheus-net for .Net and we only ever list one type of client library or exporter in order to make it easier for users not familir with the intricacies of client libraries and to also encourage collaboration towards one good and canonical library per language/VM. I'd suggest seeing if you can work with the existing .Net library.

From a quick peek, your labelname validation isn't quite right it's reusing the metric name validation rather than the separate rules for labelnames.

Brian
 

Looking forward to your kind reply and feedbacks!
Cheers,

Mark

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsub...@googlegroups.com.
To post to this group, send email to prometheus-developers@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/a1cf5e26-00ce-4623-a03d-4a75b67a4954%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--

Mark Farkas

unread,
Sep 22, 2017, 4:07:35 AM9/22/17
to Brian Brazil, Prometheus Developers
Hi Brian,

Thanks for the feedback.
We are well aware of prometheus-net, however we have met the following limitations/circumstances regarding the project:

+ .NET Core was unsupported at the time we started working on this project. Officially it is still not supported.
+ There are a lot of open issues, generally the reaction on the maintainers' side is very slow, the repository seems to be not maintained well enough.
+ Pull requests are generally ignored, the repository is forked many times for the sake of different bug fixes which are not merged to the master
+ The library has Visual Studio 2013 project files and the NuGet package officially only supports .NET Framework
+ This is generally a one man project, with not enough attention, focus and momentum to become an official API for Prometheus.

Do you see any chance to list our lib under CoreCLR?

Thanks for your quick peer, we investigate it!

Kind regards,
Mark

On Fri, Sep 22, 2017 at 9:02 AM, Brian Brazil <brian....@robustperception.io> wrote:
On 22 September 2017 at 01:05, Mark Farkas <farka...@gmail.com> wrote:
Hi!

We have created an open-source library at my company for collecting application metrics in .NET.

Do you think it would be worth to take a look and refer it somewhere in the Prometheus documentation?

Thanks for sharing. We already list https://github.com/andrasm/prometheus-net for .Net and we only ever list one type of client library or exporter in order to make it easier for users not familir with the intricacies of client libraries and to also encourage collaboration towards one good and canonical library per language/VM. I'd suggest seeing if you can work with the existing .Net library.

From a quick peek, your labelname validation isn't quite right it's reusing the metric name validation rather than the separate rules for labelnames.

Brian
 

Looking forward to your kind reply and feedbacks!
Cheers,

Mark

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscri...@googlegroups.com.



--

Brian Brazil

unread,
Sep 22, 2017, 4:47:51 AM9/22/17
to Mark Farkas, Prometheus Developers
On 22 September 2017 at 09:07, Mark Farkas <farka...@gmail.com> wrote:
Hi Brian,

Thanks for the feedback.
We are well aware of prometheus-net, however we have met the following limitations/circumstances regarding the project:

+ .NET Core was unsupported at the time we started working on this project. Officially it is still not supported.
+ The library has Visual Studio 2013 project files and the NuGet package officially only supports .NET Framework

We're not exactly experts in the .Net ecosystem, so I'm presuming it's like the JVM and once you have a jar equivalent (assembly?) that it works everywhere on the CLR.

I note that your repo also appears to be using NuGet.

+ There are a lot of open issues, generally the reaction on the maintainers' side is very slow, the repository seems to be not maintained well enough.
+ Pull requests are generally ignored, the repository is forked many times for the sake of different bug fixes which are not merged to the master
+ This is generally a one man project, with not enough attention, focus and momentum to become an official API for Prometheus.

Do you see any chance to list our lib under CoreCLR?

I generally only replace one listing with another when there is an obvious significant improvement in areas such as following the guidelines, usage and featureset.

At first glance a project developed in the past month and with no downloads reported on nuget is unlikely to supplant one that's been developed over 2 years by 10+ people with 14k downloads and which is still active. I'd suggest engaging the maintainer and rest of the community around the existing client to try and find a common path forward.

Brian

 

Thanks for your quick peer, we investigate it!

Kind regards,
Mark

On Fri, Sep 22, 2017 at 9:02 AM, Brian Brazil <brian.brazil@robustperception.io> wrote:
On 22 September 2017 at 01:05, Mark Farkas <farka...@gmail.com> wrote:
Hi!

We have created an open-source library at my company for collecting application metrics in .NET.

Do you think it would be worth to take a look and refer it somewhere in the Prometheus documentation?

Thanks for sharing. We already list https://github.com/andrasm/prometheus-net for .Net and we only ever list one type of client library or exporter in order to make it easier for users not familir with the intricacies of client libraries and to also encourage collaboration towards one good and canonical library per language/VM. I'd suggest seeing if you can work with the existing .Net library.

From a quick peek, your labelname validation isn't quite right it's reusing the metric name validation rather than the separate rules for labelnames.

Brian
 

Looking forward to your kind reply and feedbacks!
Cheers,

Mark

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscri...@googlegroups.com.
To post to this group, send email to prometheus-developers@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/a1cf5e26-00ce-4623-a03d-4a75b67a4954%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--




--

Mark Farkas

unread,
Sep 22, 2017, 5:09:44 AM9/22/17
to Brian Brazil, Prometheus Developers
Hi Brian,

Unfortunately this is not the case. .NET Framework contains APIs that are not present in .NET Core, hence they both need to support a common API subset called .NET Standard.
prometheus-net does not do this officially.

I understand your point about the replacement and I am not asking you to replace prometheus-net but to list our repository as a working solution and an alternative for those who are developing solutions on .NET Core and using Prometheus. Btw. the project was not developed last month, we have been using it in production for like a year and it is still actively developed by full-time NEXOGEN employees.

We deliberately did not use the original library as we could not wait 3+ weeks for pull requests containing bug fixes to merge. Btw. 95% of the commits were from a single guy hence I would not say this is a 10+ people project.

Cheers,
Mark

Brian Brazil

unread,
Sep 22, 2017, 5:40:28 AM9/22/17
to Mark Farkas, Prometheus Developers
On 22 September 2017 at 10:09, Mark Farkas <farka...@gmail.com> wrote:
Hi Brian,

Unfortunately this is not the case. .NET Framework contains APIs that are not present in .NET Core, hence they both need to support a common API subset called .NET Standard.
prometheus-net does not do this officially.

That implies to me that it does it unofficially.
 

I understand your point about the replacement and I am not asking you to replace prometheus-net but to list our repository as a working solution and an alternative for those who are developing solutions on .NET Core and using Prometheus. Btw. the project was not developed last month, we have been using it in production for like a year and it is still actively developed by full-time NEXOGEN employees.

Sounds to me like you should work together to produce a library that works on .Net Standard.

It's not me you need to convince here, it's the .Net community who uses Prometheus. I don't have the time to learn all the intricacies here, if the community makes your library the defacto standard then we can talk about changing the listing.

I purposefully do not list more than one library or exporters in the same general space, preferring instead to try and rally the community around one project.

Brian 
 

We deliberately did not use the original library as we could not wait 3+ weeks for pull requests containing bug fixes to merge. Btw. 95% of the commits were from a single guy hence I would not say this is a 10+ people project.

Cheers,
Mark




--

Mark Farkas

unread,
Sep 22, 2017, 6:32:04 AM9/22/17
to Brian Brazil, Prometheus Developers
Hi Brian,

I perfectly understand, we'll see where to go from here.
Anyway, thanks for your remarks regarding the bug.

Kind regards,
Mark

Reply all
Reply to author
Forward
0 new messages