Proposal: Adopting rust-open-metrics-client as official Rust client

116 views
Skip to first unread message

Max Inden

unread,
Nov 27, 2021, 11:09:14 AM11/27/21
to prometheus...@googlegroups.com
Hi there,


I would like to propose adopting
https://github.com/mxinden/rust-open-metrics-client as the official Rust
Prometheus client library.

Next to the source code on GitHub you may find detailed documentation
along with various examples on https://docs.rs/open-metrics-client/ as
well as a comparison with the popular rust-prometheus library on
https://github.com/tikv/rust-prometheus/issues/392.

# Open Issues

In case we reach general consensus on the above, the following issues
still need to be discussed.

## Naming on crates.io

Today the library is published on crates.io (the Rust package registry)
as "open-metrics-client" [1]. The crate name "prometheus" is already
taken on crates.io [2].

Would you want to keep the "open-metrics-client" name on crates.io?

## Code repository

Should we keep the source code at github.com/mxinden for now? Or should
we move the source code to github.com/prometheus-community as an
intermediary step? Or would we want to move it to github.com/prometheus
directly?


Regards,
Max

OpenPGP_signature

Julien Pivotto

unread,
Nov 27, 2021, 12:12:08 PM11/27/21
to Max Inden, Prometheus Developers
We could follow python and call it prometheus-client. In pypi, Prometheus is also a community made package.

I would move the repository directly under GitHub.com/Prometheus/client_rust. I really would love to have a fully supported rust implementation and I do not think we need an intermediate step via Prometheus-community.

Regards,

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/7174ebe6-5dca-b322-c067-3f48d64b3353%40gmail.com.

Matthias Rampke

unread,
Nov 27, 2021, 6:12:32 PM11/27/21
to Julien Pivotto, Max Inden, Prometheus Developers
+1 for putting it in the prometheus org, we should have an official client for all the popular languages, amd official clients should be in the community org with the implied promise of support.

/MR

Max Inden

unread,
Jan 13, 2022, 3:07:49 PM1/13/22
to Matthias Rampke, Julien Pivotto, Prometheus Developers
Late reply. Sorry about that.


> amd official clients should be in the community org with the implied promise of support.

I am not quite sure I follow Matthias. What does "amd" stand for?


> We could follow python and call it prometheus-client.

> I would move the repository directly under GitHub.com/Prometheus/client_rust.

I like these two suggestions. I would proceed with the following:

1. Move https://github.com/mxinden/rust-open-metrics-client to
https://github.com/prometheus/client_rust

2. Move https://crates.io/crates/open-metrics-client to
https://crates.io/crates/prometheus-client

Any objections? If not I will start the transition over the weekend.


On 28.11.21 00:12, Matthias Rampke wrote:
> +1 for putting it in the prometheus org, we should have an official
> client for all the popular languages, amd official clients should be in
> the community org with the implied promise of support.
>
> /MR
>
> On Sat, 27 Nov 2021, 18:12 Julien Pivotto, <roidel...@prometheus.io
> <mailto:roidel...@prometheus.io>> wrote:
>
> We could follow python and call it prometheus-client. In pypi,
> Prometheus is also a community made package.
>
> I would move the repository directly under
> GitHub.com/Prometheus/client_rust. I really would love to have a
> fully supported rust implementation and I do not think we need an
> intermediate step via Prometheus-community.
>
> Regards,
>
> Le sam. 27 nov. 2021, 17:09, Max Inden <ind...@gmail.com
> <mailto:ind...@gmail.com>> a écrit :
>
> Hi there,
>
>
> I would like to propose adopting
> https://github.com/mxinden/rust-open-metrics-client
> <https://github.com/mxinden/rust-open-metrics-client> as the
> official Rust
> Prometheus client library.
>
> Next to the source code on GitHub you may find detailed
> documentation
> along with various examples on
> https://docs.rs/open-metrics-client/
> <https://docs.rs/open-metrics-client/> as
> well as a comparison with the popular rust-prometheus library on
> https://github.com/tikv/rust-prometheus/issues/392
> <https://github.com/tikv/rust-prometheus/issues/392>.
>
> # Open Issues
>
> In case we reach general consensus on the above, the following
> issues
> still need to be discussed.
>
> ## Naming on crates.io <http://crates.io>
>
> Today the library is published on crates.io <http://crates.io>
> (the Rust package registry)
> as "open-metrics-client" [1]. The crate name "prometheus" is already
> taken on crates.io <http://crates.io> [2].
>
> Would you want to keep the "open-metrics-client" name on
> crates.io <http://crates.io>?
>
> ## Code repository
>
> Should we keep the source code at github.com/mxinden
> <http://github.com/mxinden> for now? Or should
> we move the source code to github.com/prometheus-community
> <http://github.com/prometheus-community> as an
> intermediary step? Or would we want to move it to
> github.com/prometheus <http://github.com/prometheus>
> directly?
>
>
> Regards,
> Max
>
> --
> You received this message because you are subscribed to the
> Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from
> it, send an email to
> prometheus-devel...@googlegroups.com
> <mailto:prometheus-developers%2Bunsu...@googlegroups.com>.
> <https://groups.google.com/d/msgid/prometheus-developers/7174ebe6-5dca-b322-c067-3f48d64b3353%40gmail.com>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to prometheus-devel...@googlegroups.com
> <mailto:prometheus-devel...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0o7e-cytj8r1%3DraHzRK57BVqd1F9iZzYnZphbQFBtc%2BOw%40mail.gmail.com
> <https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0o7e-cytj8r1%3DraHzRK57BVqd1F9iZzYnZphbQFBtc%2BOw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
OpenPGP_signature

Matthias Rampke

unread,
Jan 13, 2022, 3:13:13 PM1/13/22
to Max Inden, Julien Pivotto, Prometheus Developers
> What does "amd" stand for?

Just fat fingers 😂 should have been "and"

/MR

Matthias Rampke

unread,
Jan 13, 2022, 3:40:26 PM1/13/22
to Max Inden, Julien Pivotto, Prometheus Developers
For the public record – with "and" the sentence was even more confusing. What I really meant to write was "official clients should be in the official org".

+1 to the plan!

/MR

Richard Hartmann

unread,
Jan 14, 2022, 2:05:08 AM1/14/22
to Julien Pivotto, Max Inden, Prometheus Developers
+1

Sent by mobile; please excuse my brevity.

Max Inden

unread,
Jan 16, 2022, 3:45:43 PM1/16/22
to Prometheus Developers, Julien Pivotto, Matthias Rampke
For the record:

- Repository has been moved https://github.com/prometheus/client_rust/

- Crate has been renamed https://crates.io/crates/prometheus-client/

- Latest commit has been released as v0.15.0
https://crates.io/crates/prometheus-client/0.15.0

Hope you all enjoy using the library.

Max
> > <mailto:roidel...@prometheus.io
> <mailto:roidel...@prometheus.io>>> wrote:
> >
> >     We could follow python and call it prometheus-client. In
> pypi,
> >     Prometheus is also a community made package.
> >
> >     I would move the repository directly under
> >     GitHub.com/Prometheus/client_rust. I really would love to
> have a
> >     fully supported rust implementation and I do not think we
> need an
> >     intermediate step via Prometheus-community.
> >
> >     Regards,
> >
> >     Le sam. 27 nov. 2021, 17:09, Max Inden <ind...@gmail.com
> <mailto:ind...@gmail.com>
> >     <mailto:ind...@gmail.com <mailto:ind...@gmail.com>>> a
> <http://crates.io <http://crates.io>>
> >
> >         Today the library is published on crates.io
> <http://crates.io> <http://crates.io <http://crates.io>>
> >         (the Rust package registry)
> >         as "open-metrics-client" [1]. The crate name
> "prometheus" is already
> >         taken on crates.io <http://crates.io>
> <http://crates.io <http://crates.io>> [2].
> >
> >         Would you want to keep the "open-metrics-client" name on
> > crates.io <http://crates.io> <http://crates.io
> <http://crates.io>>?
> >
> >         ## Code repository
> >
> >         Should we keep the source code at github.com/mxinden
> <http://github.com/mxinden>
> >         <http://github.com/mxinden
> <http://github.com/mxinden>> for now? Or should
> >         we move the source code to
> github.com/prometheus-community
> <http://github.com/prometheus-community>
> >         <http://github.com/prometheus-community
> <http://github.com/prometheus-community>> as an
> >         intermediary step? Or would we want to move it to
> > github.com/prometheus <http://github.com/prometheus>
> <http://github.com/prometheus <http://github.com/prometheus>>
> >         directly?
> >
> >
> >         Regards,
> >         Max
> >
> >         --
> >         You received this message because you are subscribed
> to the
> >         Google Groups "Prometheus Developers" group.
> >         To unsubscribe from this group and stop receiving
> emails from
> >         it, send an email to
> > prometheus-devel...@googlegroups.com
> <mailto:prometheus-developers%2Bunsu...@googlegroups.com>
> >
>  <mailto:prometheus-developers%2Bunsu...@googlegroups.com
> <mailto:prometheus-developers%252Buns...@googlegroups.com>>.
> >         To view this discussion on the web visit
> >
> https://groups.google.com/d/msgid/prometheus-developers/7174ebe6-5dca-b322-c067-3f48d64b3353%40gmail.com
> <https://groups.google.com/d/msgid/prometheus-developers/7174ebe6-5dca-b322-c067-3f48d64b3353%40gmail.com>
> >
>  <https://groups.google.com/d/msgid/prometheus-developers/7174ebe6-5dca-b322-c067-3f48d64b3353%40gmail.com <https://groups.google.com/d/msgid/prometheus-developers/7174ebe6-5dca-b322-c067-3f48d64b3353%40gmail.com>>.
> >
> >     --
> >     You received this message because you are subscribed to
> the Google
> >     Groups "Prometheus Developers" group.
> >     To unsubscribe from this group and stop receiving emails
> from it,
> >     send an email to
> prometheus-devel...@googlegroups.com
> <mailto:prometheus-developers%2Bunsu...@googlegroups.com>
> >
>  <mailto:prometheus-devel...@googlegroups.com
> <mailto:prometheus-developers%2Bunsu...@googlegroups.com>>.
> >     To view this discussion on the web visit
> >
> https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0o7e-cytj8r1%3DraHzRK57BVqd1F9iZzYnZphbQFBtc%2BOw%40mail.gmail.com
> <https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0o7e-cytj8r1%3DraHzRK57BVqd1F9iZzYnZphbQFBtc%2BOw%40mail.gmail.com>
> >
>  <https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0o7e-cytj8r1%3DraHzRK57BVqd1F9iZzYnZphbQFBtc%2BOw%40mail.gmail.com?utm_medium=email&utm_source=footer <https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0o7e-cytj8r1%3DraHzRK57BVqd1F9iZzYnZphbQFBtc%2BOw%40mail.gmail.com?utm_medium=email&utm_source=footer>>.
> >
>
OpenPGP_signature

Julien Pivotto

unread,
Jan 16, 2022, 6:22:07 PM1/16/22
to Max Inden, Prometheus Developers, Matthias Rampke
On 16 Jan 21:45, Max Inden wrote:
> For the record:
>
> - Repository has been moved https://github.com/prometheus/client_rust/
>
> - Crate has been renamed https://crates.io/crates/prometheus-client/
>
> - Latest commit has been released as v0.15.0
> https://crates.io/crates/prometheus-client/0.15.0
>
> Hope you all enjoy using the library.

Max,

Can we already tweet about it?

Regards,
--
Julien Pivotto
@roidelapluie
Reply all
Reply to author
Forward
0 new messages