Getting started on porting to Fedora. I have a couple of questions
goozbach
well on Fedora.
I've already made a couple of improvements and changes:
https://github.com/philcryer/lipsync/pull/4 but I do have a couple
implementation/design questions:
1) Why not use a lipsync-specific ssh-key and corresponding ~/.ssh/
config section?
2) What are the design ideas/goals for making lipsync able to handle
multiple users?
* The fact that there is a single-user daemon and config file in /
etc/ for a specific user seems kinda backwards. Shouldn't per-user
configuration be in ${HOME}/.lipsync/ ?
3) I didn't understand the logic of one of the lines in install.sh.
Further question is in the pull request here:
https://github.com/goozbach/lipsync/commit/22b7f88228c664023478ac93af1d9ad841517661#L0L121
Phil Cryer
> Love the project. So much so I've started on a path to get it running
> well on Fedora.
>
> I've already made a couple of improvements and changes:
> https://github.com/philcryer/lipsync/pull/4 but I do have a couple
> implementation/design questions:
>
> 1) Why not use a lipsync-specific ssh-key and corresponding ~/.ssh/
> config section?
Why not indeed, that's a great idea. Will look into it.
>
> 2) What are the design ideas/goals for making lipsync able to handle
> multiple users?
I haven't had any, and yes, having it in ~/$HOME/.lipsync/ is where I
want it to be, then when /etc/init.d/lipsyncd is called, it does a
loop through all /home/*/ dirs, and if it finds the ~/$HOME/.lipsync/
it'll know to kick it off for that user. This is how the commandline
dropbox app works btw, but they use a var in the init.d script to
identify the users - something I'd like to get away from:
[..]
#DROPBOX_USERS="user1 user2"
DROPBOX_USERS="phil"
DAEMON=.dropbox/dropbox
start() {
echo "Starting dropbox..."
for dbuser in $DROPBOX_USERS; do
HOMEDIR=`getent passwd $dbuser | cut -d: -f6`
if [ -x $HOMEDIR/$DAEMON ]; then
HOME="$HOMEDIR" start-stop-daemon -b -o -c $dbuser -S -u
$dbuser -x $HOMEDIR/$DAEMON
fi
done
}
P
>
> * The fact that there is a single-user daemon and config file in /
> etc/ for a specific user seems kinda backwards. Shouldn't per-user
> configuration be in ${HOME}/.lipsync/ ?
>
> 3) I didn't understand the logic of one of the lines in install.sh.
> Further question is in the pull request here:
> https://github.com/goozbach/lipsync/commit/22b7f88228c664023478ac93af1d9ad841517661#L0L121
>
>
Phil Cryer
hack on them if they want).
https://github.com/philcryer/lipsync/issues?sort=created&direction=desc&state=open
I'm just starting use find/use all the features of github, it's
awesome! Thanks again for the code and comments goozbach
P