[PATCH] bug fix: Make sure to use string with os.walk

8 views
Skip to first unread message

Aline Manera

unread,
Dec 17, 2013, 1:37:47 PM12/17/13
to Project Kimchi
From: Aline Manera <ali...@br.ibm.com>

When kimchi is installed in the system, deep scan failed with the following
error:

Error in async_task 1
Error in async_task 1
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/kimchi/asynctask.py", line 70, in _run_helper
self.fn(cb, opaque)
File "/usr/lib/python2.7/dist-packages/kimchi/scan.py", line 87, in start_scan
probe_iso(None, scan_params)
File "/usr/lib/python2.7/dist-packages/kimchi/isoinfo.py", line 290, in probe_iso
for root, dirs, files in os.walk(loc):
File "/usr/lib/python2.7/os.py", line 294, in walk
for x in walk(new_path, topdown, onerror, followlinks):
File "/usr/lib/python2.7/os.py", line 294, in walk
for x in walk(new_path, topdown, onerror, followlinks):
File "/usr/lib/python2.7/os.py", line 294, in walk
for x in walk(new_path, topdown, onerror, followlinks):
File "/usr/lib/python2.7/os.py", line 284, in walk
if isdir(join(top, name)):
File "/usr/lib/python2.7/posixpath.py", line 80, in join
path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 8: ordinal not in range(128)

It is because os.walk expect a string and kimchi is using unicode.
So encode the path before call os.walk to avoid this problem.

Signed-off-by: Aline Manera <ali...@br.ibm.com>
---
src/kimchi/isoinfo.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kimchi/isoinfo.py b/src/kimchi/isoinfo.py
index 4544931..219fda0 100644
--- a/src/kimchi/isoinfo.py
+++ b/src/kimchi/isoinfo.py
@@ -276,7 +276,7 @@ def _probe_iso(fname, remote = False):


def probe_iso(status_helper, params):
- loc = params['path']
+ loc = params['path'].encode("utf-8")
updater = params['updater']
ignore = False
ignore_list = params['ignore_list']
--
1.7.10.4

Daniel Henrique Barboza

unread,
Dec 17, 2013, 1:55:40 PM12/17/13
to project...@googlegroups.com
Reviewed-by: Daniel Barboza <dani...@linux.vnet.ibm.com>

Aline Manera

unread,
Dec 17, 2013, 2:08:41 PM12/17/13
to Aline Manera, Project Kimchi
Applied. Thanks.

Regards,

Aline Manera

Reply all
Reply to author
Forward
0 new messages