Updating a column for multiple rows

[Da-Omiete Iboroma]

Hello, please I am trying to generate passcodes then updating the passcodes colunm in the database for all the rows.  My code is just updating one row and then it will stop.  Please help me out.

$sql5 = "

SELECT *

FROM $table_name

WHERE passcode = ''

";

$result =  mysql_query($sql5,$connection) or die("couldn't connect.");

$j = 1;

while ($row = mysql_fetch_array($result))

{

$_POST["matric_id"] = $row['matric'];

function random_string($length)

{

$key = '';

$keys = array_merge(range(1, 9), range('A', 'Z'));

for ($i = 0; $i < $length; $i++) 

{

$key .= $keys[array_rand($keys)];

}

return $key;

}

$passcode = random_string(8); 

$sql1 = "

UPDATE $table_name SET

passcode = '$passcode'

WHERE matric = '$_POST[matric_id]'

";

$result = mysql_query($sql1,$connection) or die(mysql_error());

}

$j++;

Thanks

[Robert Gonzalez]

Probably because you are generating an error in the second iteration. You can only define a function once. You are defining that function in a loop. You should define your function outside of the loop then call that function from the loop.

There are other areas to be improved, but that one stands out to me the most.

--

Robert Gonzalez

   

[Da-Omiete Iboroma]

Thanks Savla Jigs, I tried it but I am still having the same result. I will just update one record and stop.  I am getting this warning 

Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given

Thanks. 

On Wed, Feb 3, 2016 at 2:40 PM, savla jigs <savla...@gmail.com> wrote:

$sql5 = "SELECT * FROM $table_name WHERE passcode = ''

";

$result = mysql_query($sql5, $connection) or die("couldn't connect.");

$j = 1;

function random_string($length) {

    $key = '';

    $keys = array_merge(range(1, 9), range('A', 'Z'));

    for ($i = 0; $i < $length; $i++) {

        $key .= $keys[array_rand($keys)];

    }

    return $key;

}

while ($row = mysql_fetch_array($result)) {

    $_POST["matric_id"] = $row['matric'];

    $passcode = random_string(8);

    $sql1 = "UPDATE $table_name SET passcode = '$passcode' WHERE matric = '".$_POST["matric_id"]."'";

    $result = mysql_query($sql1, $connection) or die(mysql_error());

}

$j++;

Try this and let me know.

Thanks & Regard,

Jigar Savla | Software Engineer  

M - 997 080 0919  | E - savla...@gmail.com 

Twitter - @savlajigar | Facebook - @savlajig

Save Paper, Save Trees, Save the Planet.

Please do not print until & unless it is very necessary.

--
This group is managed by the web application development team at www.360psg.com
---
You received this message because you are subscribed to the Google Groups "Professional PHP Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to professional-p...@googlegroups.com.
Visit this group at https://groups.google.com/group/professional-php.
To view this discussion on the web visit https://groups.google.com/d/msgid/professional-php/CAERp-YOTLbWPqWZir1OfUSqiHLjBen5dTjz3VbSNeuGbaaXPdA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

[David Dyess]

The last $result var needs to be changed, you are overriding the original $result var

To view this discussion on the web visit https://groups.google.com/d/msgid/professional-php/CAJOK3gWTwHcKHB-vgO8%2BW1nwLhXFq7L7gf5QQhVrEf_Jum1_-Q%40mail.gmail.com.

[Da-Omiete Iboroma]

Thanks alot, it WORKED.  I renamed the last $result variable to $result2.  The final code is;

$sql5 = "SELECT * FROM $table_name WHERE passcode = ''

";

$result = mysql_query($sql5, $connection) or die("couldn't connect.");

$j = 1;

function random_string($length) {

$key = '';

$keys = array_merge(range(1, 9), range('A', 'Z'));

for ($i = 0; $i < $length; $i++) {

$key .= $keys[array_rand($keys)];

}

return $key;

}

while ($row = mysql_fetch_array($result)) {

$_POST["matric_id"] = $row['matric'];

$passcode = random_string(8);

$sql1 = "UPDATE $table_name SET passcode = '$passcode' WHERE matric = '".$_POST["matric_id"]."'";

$result2 = mysql_query($sql1, $connection) or die(mysql_error());

}

$j++;

Thanks to all of you for helping

To view this discussion on the web visit https://groups.google.com/d/msgid/professional-php/CAOj8Mue3hN3hbEiDyqHPu640RATRihKEk52ukzKmCfwZOGj2og%40mail.gmail.com.