FITB outside of exercise

1 view

Skip to first unread message

D. Brian Walton

unread,

Jul 19, 2024, 6:53:38 PM (4 days ago) Jul 19

to pretext-dev

I believe I have fill-in-the-blank working in tasks and &PROJECT-LIKE; and am ready to make a pull-request. So this is almost at an announcement level for the bleeding-edge users to start beating on it to see where rough edges need to be polished.

BUT I have a git question, probably mainly for Rob.

Prior to breaking out the FITB from #exercise, I updated the previous work to add examples in the sample-book. The commit history was actually based on my previous branch that was used in the previous pull-request as I was in the middle of getting that ready based on a PR comment that this was needed when Rob merged that PR.

So PR#2220 has sample-book examples but has this weird branch history.

My ready-to-go PR requires building off the sample-book problems but adds the new features of allowing fill-ins in many more areas.

Should I push this onto the existing PR? Or create a new PR that is clean that includes the sample-book work but also the new features. I think this requires a rebase to only address changes relative to the current master branch.