PTParser: RhythmSlash bug?

3 views
Skip to first unread message

Simone Tellini

unread,
Sep 27, 2007, 2:24:09 PM9/27/07
to powertab-...@googlegroups.com
Hi,

I think there's a small bug in the RhythmSlash class. It defines:

// Single Note String Number Constants
const wxByte RhythmSlash::MIN_SINGLE_NOTE_STRING_NUMBER = 1;
const wxByte RhythmSlash::MAX_SINGLE_NOTE_STRING_NUMBER = 7;

which are used by:

static bool IsValidStringNumber(wxByte stringNumber) {return
((stringNumber >= MIN_SINGLE_NOTE_STRING_NUMBER) && (stringNumber <=
MAX_SINGLE_NOTE_STRING_NUMBER));}

As far as I've seen, though, string numbers are 0-based, thus either
the constants or IsValidStringNumber() should be modified.

--
Simone Tellini
http://www.tellini.org

Dummy

unread,
Sep 27, 2007, 8:38:33 PM9/27/07
to Power Tab Developers Support
Fixed in the latest source.

Thanks Simone.

Reply all
Reply to author
Forward
0 new messages