[PATCH 1/2] CI: enable -Werror for builds

[Nathan Lynch]

The CI builds all seem to be warning-free. Ensure we fail runs when
new warnings are introduced.

Signed-off-by: Nathan Lynch <nat...@linux.ibm.com>
---
.github/workflows/main.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 1a6c9a3d6b44..af95dbda494e 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -86,7 +86,7 @@ jobs:

- name: configure
run: |
- ./configure --prefix=/usr --host=${{ matrix.host }} --disable-werror --build=x86_64-linux-gnu CFLAGS='-O2 -g'
+ ./configure --prefix=/usr --host=${{ matrix.host }} --enable-werror --build=x86_64-linux-gnu CFLAGS='-O2 -g'

- name: Collect config.log
if: ${{ failure() }}
@@ -100,4 +100,4 @@ jobs:

- name: distcheck
run: |
- make distcheck V=1 DISTCHECK_CONFIGURE_FLAGS='--disable-werror --host=${{ matrix.host }}'
+ make distcheck V=1 DISTCHECK_CONFIGURE_FLAGS='--enable-werror --host=${{ matrix.host }}'
--
2.39.0

[John Paul Adrian Glaubitz]

Hi Nathan!

On 1/4/23 21:02, Nathan Lynch wrote:
> The CI builds all seem to be warning-free. Ensure we fail runs when
> new warnings are introduced.

I assume the CI is using an older GCC version which is why the warnings
aren't visible yet. In Debian, they started to show up with GCC-12.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

[Nathan Lynch]

John Paul Adrian Glaubitz <glau...@physik.fu-berlin.de> writes:
> On 1/4/23 21:02, Nathan Lynch wrote:
>> The CI builds all seem to be warning-free. Ensure we fail runs when
>> new warnings are introduced.
>
> I assume the CI is using an older GCC version which is why the warnings
> aren't visible yet. In Debian, they started to show up with GCC-12.

Yes, it looks like the current CI image for the project uses GCC 9.

[Tyrel Datwyler]

On 1/4/23 12:05, John Paul Adrian Glaubitz wrote:
> Hi Nathan!
>
> On 1/4/23 21:02, Nathan Lynch wrote:
>> The CI builds all seem to be warning-free. Ensure we fail runs when
>> new warnings are introduced.
>
> I assume the CI is using an older GCC version which is why the warnings
> aren't visible yet. In Debian, they started to show up with GCC-12.

Our build CI uses github actions which restricts us to Ubuntu runners. GCC-10 is
the latest with Ubuntu 20.04 which the CI is currently using. Even when I tried
Ubuntu 22.04 it still wasn't bleeding edge enough for GCC-12 to be available.

-Tyrel