[PATCH 1/4] drmgr/common: introduce action to string table

[Laurent Dufour]

This will be used to convert action into environment variable when running
hooks.

Signed-off-by: Laurent Dufour <ldu...@linux.ibm.com>
---
src/drmgr/common.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/src/drmgr/common.c b/src/drmgr/common.c
index 9cd91d1d627a..b80d01e5c75f 100644
--- a/src/drmgr/common.c
+++ b/src/drmgr/common.c
@@ -76,6 +76,17 @@ static char *hook_phase_name[] = {
[HOOK_POST] = "post",
};

+static char *hook_action_name[] = {
+ [NONE] = "none",
+ [ADD] = "add",
+ [REMOVE] = "remove",
+ [QUERY] = "query",
+ [REPLACE] = "replace",
+ [IDENTIFY] = "identify",
+ [MIGRATE] = "migrate",
+ [HIBERNATE] = "hibernate",
+};
+
/**
* set_output level
* @brief Common routine to set the output level
--
2.39.2

[Nathan Lynch]

Laurent Dufour <ldu...@linux.ibm.com> writes:
> This will be used to convert action into environment variable when running
> hooks.
>
> Signed-off-by: Laurent Dufour <ldu...@linux.ibm.com>
> ---
> src/drmgr/common.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/drmgr/common.c b/src/drmgr/common.c
> index 9cd91d1d627a..b80d01e5c75f 100644
> --- a/src/drmgr/common.c
> +++ b/src/drmgr/common.c
> @@ -76,6 +76,17 @@ static char *hook_phase_name[] = {
> [HOOK_POST] = "post",
> };
>
> +static char *hook_action_name[] = {
> + [NONE] = "none",
> + [ADD] = "add",
> + [REMOVE] = "remove",
> + [QUERY] = "query",
> + [REPLACE] = "replace",
> + [IDENTIFY] = "identify",
> + [MIGRATE] = "migrate",
> + [HIBERNATE] = "hibernate",
> +};

Could use some const qualifiers.

I assume the following patches actually use hook_action_name, but I
would expect this patch on its own to introduce a defined-but-not-used
compiler warning.

[Laurent Dufour]

Yes

> I assume the following patches actually use hook_action_name, but I
> would expect this patch on its own to introduce a defined-but-not-used
> compiler warning.

Fair enough, I can squash it into the next one.

[Tyrel Datwyler]

Yes, this needs to be const, as should the previous two declarations of
drc_type_str[] and hook_phase_name[] which was missed in the previous hook
patchset. Please send a follow up patch to fix those as well.

-Tyrel