Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Status.HasWorking doesn't take into account added files

8 views
Skip to first unread message

Jean-Francois Cantin

unread,
Mar 23, 2010, 6:52:43 PM3/23/10
to posh...@googlegroups.com
Hi,

Don't know if it was intended like this or not. Here is how to reproduce this: Initial state of 1 modified file and 1 new file.
Staging the modified file gives you [master +0 ~1 -0 !] in blue
where my expectation was [master +0 ~1 -0 | +1 ~0 -0 !]

I updated Status.HasWorking with the following OR condition
HasWorking      = [bool]$diffFiles -or [bool]$filesAdded

I was going to do a pull request, but we have different line endings.

Best,

Jean-Francois

Keith Dahlby

unread,
Mar 23, 2010, 8:03:18 PM3/23/10
to posh...@googlegroups.com
Good catch - I'll get this fixed when I pull in Mark's changes.

Cheers ~
Keith

To unsubscribe from this group, send email to posh-git+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.

Mark Embling

unread,
Mar 24, 2010, 4:48:13 AM3/24/10
to posh...@googlegroups.com
Jean-Francois,
Nice find, thanks. I have to admit, I'd never noticed that but you are quite right, it shouldn't act that way. :)

Keith,
I have implemented this change in my fork (master branch). If/when you pull down my changes, you should get this fix too.

Keith Dahlby

unread,
Mar 25, 2010, 4:20:41 AM3/25/10
to posh-git
This has been fixed in my trunk as well.

On Mar 24, 3:48 am, Mark Embling <cont...@markembling.info> wrote:
> *Jean-Francois,*


> Nice find, thanks. I have to admit, I'd never noticed that but you are quite
> right, it shouldn't act that way. :)
>

> *Keith,*


> I have implemented this change in my fork (master branch). If/when you pull
> down my changes, you should get this fix too.
>

Reply all
Reply to author
Forward
0 new messages