on-tap vs on-click in relation to 3rd party oauth and browser pop-up blocking (using firebase)

[Matt Bourne]

Think I may have run into an issue with on-tap

What seems to be happening id if I try to trigger a firebase simple login using a 3rd party provider the pop-ups are being blocked by the browser.

Doing a little bit of research it seems like browsers want pop-ups to be triggered by on-click events. If I change the trigger to an on-click the pop appears as expected without a warning.

Can anyone confirm this and also help me understand what I might lose by changing this button to an on-click from an an on-tap?

 

<paper-button hidden?="{{user}}"  label="Login with Google" on-click="{{handleLogin}}"></paper-button>

[Rob Dodson]

+ Daniel, who is the expert :)

I believe the primary difference is how/when on-click fires on touch devices.  on-click won't fire if any of the following are true:
1. The element directly under the finger does not have a mouse handler
2. You scroll
3. Another finger is touching the screen

Follow Polymer on Google+: plus.google.com/107187849809354688692
---
You received this message because you are subscribed to the Google Groups "Polymer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymer-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymer-dev/415b1707-65da-479c-9e11-1b601a6f95d3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Martin Kleinschrodt]

I was going to file an issue on this a while ago bit didn't get to this. It seems that the tap gesture does not reuse the original Mouse/Touch event. I think this could easily be fixed if the tap gesture would recycle the touchend event instead of creating a new object. If I find the time, I'll take a closer look at the polymer-gestures source and perhaps take a step and fixing this. Minimally, I'll try to create a detailed issue for this on github.